From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#12993: Wrong icon for Cygw32-Emacs Date: Mon, 08 Apr 2013 22:43:55 -0400 Message-ID: <5163806B.3060404@cornell.edu> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <5161B6E4.90508@cornell.edu> <834nfich3g.fsf@gnu.org> <5161F6D4.20402@cornell.edu> <83zjx9bvac.fsf@gnu.org> <5162BFFF.3090407@cornell.edu> <83vc7xaxb1.fsf@gnu.org> <5162E177.10601@cornell.edu> <83ip3xat2m.fsf@gnu.org> <5162F740.9020409@cornell.edu> <83fvz1aqh3.fsf@gnu.org> <516327FF.1050801@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1365475472 8089 80.91.229.3 (9 Apr 2013 02:44:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Apr 2013 02:44:32 +0000 (UTC) Cc: 12993-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 04:44:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UPOXw-0003Km-Gz for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2013 04:44:32 +0200 Original-Received: from localhost ([::1]:42932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPOXw-0005dQ-2e for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2013 22:44:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPOXs-0005dI-EV for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2013 22:44:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPOXr-0006Ck-Ds for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2013 22:44:28 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36820) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPOXr-0006Cc-Ac for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2013 22:44:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UPObK-000367-3c for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2013 22:48:02 -0400 Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2013 02:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 12993@debbugs.gnu.org, kbrown@cornell.edu, angelo.graziosi@alice.it Original-Received: via spool by 12993-done@debbugs.gnu.org id=D12993.136547567411891 (code D ref 12993); Tue, 09 Apr 2013 02:48:01 +0000 Original-Received: (at 12993-done) by debbugs.gnu.org; 9 Apr 2013 02:47:54 +0000 Original-Received: from localhost ([127.0.0.1]:40929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPObB-00035k-EN for submit@debbugs.gnu.org; Mon, 08 Apr 2013 22:47:54 -0400 Original-Received: from limestone4.mail.cornell.edu ([128.253.83.164]:56224) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPOb8-00035a-Mq for 12993-done@debbugs.gnu.org; Mon, 08 Apr 2013 22:47:52 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu ([10.16.197.8]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r392iDEg027919; Mon, 8 Apr 2013 22:44:14 -0400 (EDT) Original-Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r392iDgf028837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 8 Apr 2013 22:44:13 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: <516327FF.1050801@cornell.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73270 Archived-At: On 4/8/2013 4:26 PM, Ken Brown wrote: > On 4/8/2013 1:20 PM, Eli Zaretskii wrote: >>> Date: Mon, 08 Apr 2013 12:58:40 -0400 >>> From: Ken Brown >>> CC: dancol@dancol.org, 12993@debbugs.gnu.org >>> >>> Thank you! So I assume the correct fix is the following: >>> >>> === modified file 'nt/emacs.rc' >>> --- nt/emacs.rc 2013-03-05 03:59:35 +0000 >>> +++ nt/emacs.rc 2013-04-08 16:55:12 +0000 >>> @@ -1,6 +1,6 @@ >>> Emacs ICON icons/emacs.ico >>> 32649 CURSOR icons/hand.cur >>> -#ifdef WIN64 >>> +#if defined (WIN64) || defined (__x86_64__) >>> 1 24 "emacs-x64.manifest" >>> #else >>> 1 24 "emacs-x86.manifest" >>> >>> Right? >> >> Yes. But what about that linker directive in configure.ac -- is that >> still required? (I never understood why Cygwin needs that in the >> first place.) > > The "-Wl,-bpe-i386" part is not necessary. I just checked this on both > Cygwin32 and Cygwin64. I think it should be removed, since it's > confusing to have an unnecessary directive (especially on Cygwin64, > where the format is actually pe-x86-64). But if both directives are > removed, the icon doesn't show up. I guess the comment right before > that line in configure.ac explains why. I've removed "-Wl,-bpe-i386" and made the change to nt/emacs.rc as bzr revision 112251. I'm closing the bug report. Thanks again for your help, Eli. Ken