From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12993-done@debbugs.gnu.org
Subject: bug#12993: Wrong icon for Cygw32-Emacs
Date: Mon, 08 Apr 2013 22:43:55 -0400 [thread overview]
Message-ID: <5163806B.3060404@cornell.edu> (raw)
In-Reply-To: <516327FF.1050801@cornell.edu>
On 4/8/2013 4:26 PM, Ken Brown wrote:
> On 4/8/2013 1:20 PM, Eli Zaretskii wrote:
>>> Date: Mon, 08 Apr 2013 12:58:40 -0400
>>> From: Ken Brown <kbrown@cornell.edu>
>>> CC: dancol@dancol.org, 12993@debbugs.gnu.org
>>>
>>> Thank you! So I assume the correct fix is the following:
>>>
>>> === modified file 'nt/emacs.rc'
>>> --- nt/emacs.rc 2013-03-05 03:59:35 +0000
>>> +++ nt/emacs.rc 2013-04-08 16:55:12 +0000
>>> @@ -1,6 +1,6 @@
>>> Emacs ICON icons/emacs.ico
>>> 32649 CURSOR icons/hand.cur
>>> -#ifdef WIN64
>>> +#if defined (WIN64) || defined (__x86_64__)
>>> 1 24 "emacs-x64.manifest"
>>> #else
>>> 1 24 "emacs-x86.manifest"
>>>
>>> Right?
>>
>> Yes. But what about that linker directive in configure.ac -- is that
>> still required? (I never understood why Cygwin needs that in the
>> first place.)
>
> The "-Wl,-bpe-i386" part is not necessary. I just checked this on both
> Cygwin32 and Cygwin64. I think it should be removed, since it's
> confusing to have an unnecessary directive (especially on Cygwin64,
> where the format is actually pe-x86-64). But if both directives are
> removed, the icon doesn't show up. I guess the comment right before
> that line in configure.ac explains why.
I've removed "-Wl,-bpe-i386" and made the change to nt/emacs.rc as bzr
revision 112251. I'm closing the bug report. Thanks again for your
help, Eli.
Ken
prev parent reply other threads:[~2013-04-09 2:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 14:49 bug#12993: Wrong icon for Cygw32-Emacs Angelo Graziosi
2012-12-10 7:13 ` Daniel Colascione
2012-12-10 13:40 ` Eli Zaretskii
2012-12-10 14:08 ` Eli Zaretskii
2012-12-10 16:24 ` Daniel Colascione
2012-12-10 19:57 ` Eli Zaretskii
2012-12-10 21:05 ` Daniel Colascione
2012-12-10 16:03 ` Daniel Colascione
2012-12-10 16:34 ` Eli Zaretskii
2012-12-10 17:30 ` Stefan Monnier
2012-12-10 17:58 ` Daniel Colascione
2012-12-10 20:06 ` Eli Zaretskii
2013-04-07 18:11 ` Ken Brown
2013-04-07 18:48 ` Eli Zaretskii
2013-04-07 22:44 ` Ken Brown
2013-04-08 2:39 ` Eli Zaretskii
2013-04-08 13:02 ` Ken Brown
2013-04-08 14:53 ` Eli Zaretskii
2013-04-08 15:25 ` Ken Brown
2013-04-08 16:24 ` Eli Zaretskii
2013-04-08 16:58 ` Ken Brown
2013-04-08 17:20 ` Eli Zaretskii
2013-04-08 20:26 ` Ken Brown
2013-04-09 2:41 ` Eli Zaretskii
2013-04-09 2:43 ` Ken Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163806B.3060404@cornell.edu \
--to=kbrown@cornell.edu \
--cc=12993-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.