all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 75362@debbugs.gnu.org, Roi Martin <jroi.martin@gmail.com>
Subject: bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list
Date: Tue, 7 Jan 2025 22:18:53 -0800	[thread overview]
Message-ID: <5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com> (raw)
In-Reply-To: <zCI9Jr9K64psV3fLGw15EX5fh47mg_WOTtNXKc5gtfsuNAjZydRw5Oma0A_SgsMqf4XBq4b5h67On8loF98ysSqFvUJ1M8w6m0SCgVJNNR0=@rjt.dev>



> On Jan 5, 2025, at 2:05 PM, Randy Taylor <dev@rjt.dev> wrote:
> 
> On Saturday, January 4th, 2025 at 10:40, Roi Martin <jroi.martin@gmail.com> wrote:
>> 
>> When using the Go tree-sitter grammar v0.23.4 from
>> https://github.com/tree-sitter/tree-sitter-go.git, indentation inside
>> var lists does not work correctly.
>> 
>> For instance, the following code is indented as:
>> 
>> `var ( one = 1 )`
>> 
>> Instead of:
>> 
>> `var ( one = 1 )`
>> 
>> Just in case it can help, I think this stopped working with grammar
>> version `v0.21.1`, that introduced `var_spec_list`:
>> 
>> https://github.com/tree-sitter/tree-sitter-go/compare/v0.21.0...v0.21.1
>> 
>> Please, take it with a pinch of salt because I'm not very familiar with
>> tree-sitter.
>> 
>> [...]
>> 
> 
> Thanks for the report.
> 
> The attached patch fixes it for me.<0001-Fix-go-ts-mode-var-spec-indentation-Bug-75362.patch>

Thanks Randy. Eli, should we apply this to emacs-30.

Also, what’s the general situation of grammar fixes on emacs-30? I’m asking because I fixed a grammar compatibility issue for cmake-ts-mode on master. I was going to back port it for 30.2, but it seems that simple fixes are ok for emacs-30?

Yuan




  reply	other threads:[~2025-01-08  6:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04 15:40 bug#75362: 29.4; go-ts-mode.el: wrong indentation inside var list Roi Martin
2025-01-05 22:05 ` Randy Taylor
2025-01-08  6:18   ` Yuan Fu [this message]
2025-01-08 13:02     ` Eli Zaretskii
2025-01-08 13:20       ` Randy Taylor
2025-01-09  7:10         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5154DC1D-94C1-4B13-9D10-72488A408C6D@gmail.com \
    --to=casouri@gmail.com \
    --cc=75362@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=jroi.martin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.