From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: (0 <= i && i < N) is not "backwards" Date: Sun, 24 Mar 2013 16:14:49 -0700 Organization: UCLA Computer Science Department Message-ID: <514F88E9.2020600@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1364166900 7401 80.91.229.3 (24 Mar 2013 23:15:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Mar 2013 23:15:00 +0000 (UTC) Cc: Emacs Development To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 00:15:27 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJu8G-0008EH-4N for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2013 00:15:20 +0100 Original-Received: from localhost ([::1]:42024 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJu7s-0004zn-Bj for ged-emacs-devel@m.gmane.org; Sun, 24 Mar 2013 19:14:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJu7p-0004zd-7x for Emacs-devel@gnu.org; Sun, 24 Mar 2013 19:14:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJu7o-0002cT-7l for Emacs-devel@gnu.org; Sun, 24 Mar 2013 19:14:53 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:56646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJu7o-0002Yf-1E for Emacs-devel@gnu.org; Sun, 24 Mar 2013 19:14:52 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4B0BFA60001; Sun, 24 Mar 2013 16:14:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n4bVXb8qsAK0; Sun, 24 Mar 2013 16:14:50 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id EEB9739E8008; Sun, 24 Mar 2013 16:14:49 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158113 Archived-At: Emacs trunk bzr 112126, installed with the commit log "Reorder conditions that are written backwards", changed a lot of Emacs code, typically to replace expressions like "0 < i" with expressions like "i > 0". This sort of stylistic change shouldn't be introduced without discussion. I often prefer "<", as it causes textual order to reflect numeric order. This is not just a personal preference; it's a common style used in other GNU projects. Removing this style en masse is not called for, particularly in places where the code is checking for values in range. In one or two places the change may have introduced a bug, as "! (0 < X)" is not equivalent to "X <= 0" when X is floating point, because of NaNs. I suggest reverting the change and discussing it before applying.