all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Emacs Development <Emacs-devel@gnu.org>
Subject: (0 <= i && i < N) is not "backwards"
Date: Sun, 24 Mar 2013 16:14:49 -0700	[thread overview]
Message-ID: <514F88E9.2020600@cs.ucla.edu> (raw)

Emacs trunk bzr 112126, installed with the commit log
"Reorder conditions that are written backwards",
changed a lot of Emacs code, typically to replace expressions
like "0 < i" with expressions like "i > 0".

This sort of stylistic change shouldn't be introduced without
discussion.  I often prefer "<", as it causes textual
order to reflect numeric order.  This is not just a personal
preference; it's a common style used in other GNU projects.
Removing this style en masse is not called for, particularly
in places where the code is checking for values in range.

In one or two places the change may have introduced a bug,
as "! (0 < X)" is not equivalent to "X <= 0" when
X is floating point, because of NaNs.

I suggest reverting the change and discussing it before
applying.



             reply	other threads:[~2013-03-24 23:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 23:14 Paul Eggert [this message]
2013-03-24 23:53 ` (0 <= i && i < N) is not "backwards" Pascal J. Bourguignon
2013-03-25 14:23   ` Stefan Monnier
2013-03-25 14:59     ` Andreas Schwab
2013-03-25  8:20 ` Eli Zaretskii
2013-03-25 14:35   ` Paul Eggert
2013-03-25 14:53     ` Eli Zaretskii
2013-03-25 14:58       ` Noah Lavine
2013-03-25 15:09         ` Eli Zaretskii
2013-03-25 15:28           ` Noah Lavine
2013-03-25 16:49       ` Paul Eggert
2013-03-25 16:59         ` Eli Zaretskii
2013-03-30 21:45 ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514F88E9.2020600@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=Emacs-devel@gnu.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.