* Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation. [not found] <E1UHPdY-0006ST-OE@vcs.savannah.gnu.org> @ 2013-03-19 4:29 ` Dmitry Gutov 2013-03-19 13:00 ` Stefan Monnier 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Gutov @ 2013-03-19 4:29 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > ------------------------------------------------------------ > revno: 112071 > committer: Stefan Monnier <monnier@iro.umontreal.ca> > branch nick: trunk > timestamp: Sun 2013-03-17 21:50:32 -0400 > message: > * lisp/whitespace.el: Fix double evaluation. > (whitespace-space, whitespace-hspace, whitespace-tab) > (whitespace-newline, whitespace-trailing, whitespace-line) > (whitespace-space-before-tab, whitespace-indentation) > (whitespace-empty, whitespace-space-after-tab): Turn defcustoms into > obsolete defvars. > -(defcustom whitespace-space 'whitespace-space > +(defvar whitespace-space 'whitespace-space > "Symbol face used to visualize SPACE. > - > -Used when `whitespace-style' includes the value `spaces'." > - :type 'face > - :group 'whitespace) > +Used when `whitespace-style' includes the value `spaces'.") > +(make-obsolete-variable 'whitespace-space "use the face instead" "24.4") > - (list whitespace-space-regexp 1 whitespace-space t) > + `( > + ,@(when (memq 'spaces whitespace-active-style) > + ;; Show SPACEs. > + `((,whitespace-space-regexp 1 whitespace-space t) IIUC, this does not only make face vars obsolete, but also makes them have no effect. Was that your intention? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation. 2013-03-19 4:29 ` /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation Dmitry Gutov @ 2013-03-19 13:00 ` Stefan Monnier 2013-03-19 13:30 ` Dmitry Gutov 0 siblings, 1 reply; 3+ messages in thread From: Stefan Monnier @ 2013-03-19 13:00 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel > IIUC, this does not only make face vars obsolete, but also makes them have > no effect. What makes you think so? The FACE element of font-lock-keywords is passed to `eval' (i.e. before my patch the face used was actually (eval (eval 'whitespace-space)), hence the summary of the patch being "Fix double evaluation"). Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation. 2013-03-19 13:00 ` Stefan Monnier @ 2013-03-19 13:30 ` Dmitry Gutov 0 siblings, 0 replies; 3+ messages in thread From: Dmitry Gutov @ 2013-03-19 13:30 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel On 19.03.2013 17:00, Stefan Monnier wrote: >> IIUC, this does not only make face vars obsolete, but also makes them have >> no effect. > > What makes you think so? The FACE element of font-lock-keywords is > passed to `eval' (i.e. before my patch the face used was actually (eval > (eval 'whitespace-space)), hence the summary of the patch being "Fix double evaluation"). Ah, I see, thank you. Obviously, I didn't understand the summary. Sorry for the noise. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-19 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1UHPdY-0006ST-OE@vcs.savannah.gnu.org>
2013-03-19 4:29 ` /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation Dmitry Gutov
2013-03-19 13:00 ` Stefan Monnier
2013-03-19 13:30 ` Dmitry Gutov
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.