From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation. Date: Tue, 19 Mar 2013 17:30:50 +0400 Message-ID: <5148688A.8010005@yandex.ru> References: <87r4jc57wx.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1363699863 12119 80.91.229.3 (19 Mar 2013 13:31:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Mar 2013 13:31:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 14:31:29 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UHwdU-0007uS-BG for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2013 14:31:28 +0100 Original-Received: from localhost ([::1]:40358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwd7-0002yW-AA for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2013 09:31:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwcx-0002xQ-VC for emacs-devel@gnu.org; Tue, 19 Mar 2013 09:31:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHwcq-0001w5-0Y for emacs-devel@gnu.org; Tue, 19 Mar 2013 09:30:55 -0400 Original-Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:54667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHwcp-0001vu-NF for emacs-devel@gnu.org; Tue, 19 Mar 2013 09:30:47 -0400 Original-Received: by mail-la0-f52.google.com with SMTP id fs12so883581lab.39 for ; Tue, 19 Mar 2013 06:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding:x-antivirus:x-antivirus-status; bh=LM5WtfYL8CpT6ADjvrX/4Zh9ymyByZkXUtut/BzRje0=; b=QeZwlaU7Iu2Hs8QiTZZ2aBzZ1HK08gKEf2yiEJSzmcwD9mKExnUP7fs9SJfn1hFl+8 BpMUyDFCLdYhMpXVXHIy7923qee7byS8pFG5cIK2rW598YnM3sSeDV0PE34H9Eu96CgB NIw8ac5EFP/tfAt6wxmca+b09UntYsfIPn5P5YfoP6IfF7XjmOpVOie6vU8X/zlYBliD MTq3llvi3D9o0P+VEXE6HuPeAmycwCnATxXM+pCry8cG44v5IB3BP+INGm05/SpAgbrW k5vZOAArQb5Q7e81Hb6bDtLEyPf9SJ5aKvRrk/eid3IMnklNHyXbFP45rbQHkf0tILbM LY+w== X-Received: by 10.112.17.137 with SMTP id o9mr8125979lbd.42.1363699846596; Tue, 19 Mar 2013 06:30:46 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPS id ng6sm10921437lab.2.2013.03.19.06.30.45 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 19 Mar 2013 06:30:45 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 In-Reply-To: X-Antivirus: avast! (VPS 130318-1, 19.03.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157953 Archived-At: On 19.03.2013 17:00, Stefan Monnier wrote: >> IIUC, this does not only make face vars obsolete, but also makes them have >> no effect. > > What makes you think so? The FACE element of font-lock-keywords is > passed to `eval' (i.e. before my patch the face used was actually (eval > (eval 'whitespace-space)), hence the summary of the patch being "Fix double evaluation"). Ah, I see, thank you. Obviously, I didn't understand the summary. Sorry for the noise.