From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#13907: 24.3.50; cygw32 build mishandles drag-n-dropped file with non-ASCII characters in name Date: Sat, 09 Mar 2013 07:16:12 -0500 Message-ID: <513B280C.5020107@cornell.edu> References: <513A1D4D.5060908@cornell.edu> <8338w5zni7.fsf@gnu.org> <83vc91y6m4.fsf@gnu.org> <83txoly5ov.fsf@gnu.org> <513A5741.8060804@dancol.org> <513AA672.80903@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362831450 25680 80.91.229.3 (9 Mar 2013 12:17:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Mar 2013 12:17:30 +0000 (UTC) Cc: 13907@debbugs.gnu.org To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 09 13:17:54 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UEIin-0003ry-Hr for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Mar 2013 13:17:53 +0100 Original-Received: from localhost ([::1]:59135 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEIiR-0001Xq-Gg for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Mar 2013 07:17:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEIiK-0001Xh-M8 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 07:17:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEIiF-0001Jw-Sz for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 07:17:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEIiF-0001Jr-Po for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 07:17:19 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UEIiw-00079t-0U for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2013 07:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2013 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13907 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13907-submit@debbugs.gnu.org id=B13907.136283144227468 (code B ref 13907); Sat, 09 Mar 2013 12:18:01 +0000 Original-Received: (at 13907) by debbugs.gnu.org; 9 Mar 2013 12:17:22 +0000 Original-Received: from localhost ([127.0.0.1]:41073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEIiH-00078y-DX for submit@debbugs.gnu.org; Sat, 09 Mar 2013 07:17:22 -0500 Original-Received: from limestone4.mail.cornell.edu ([128.253.83.164]:56490) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UEIiD-00078k-Tj for 13907@debbugs.gnu.org; Sat, 09 Mar 2013 07:17:19 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu ([10.16.197.9]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id r29CGGeN000985; Sat, 9 Mar 2013 07:16:16 -0500 (EST) Original-Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r29CGLMf006635 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 9 Mar 2013 07:16:22 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: <513AA672.80903@dancol.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72271 Archived-At: On 3/8/2013 10:03 PM, Daniel Colascione wrote: > On 3/8/2013 1:25 PM, Daniel Colascione wrote: >> On 3/8/2013 12:53 PM, Eli Zaretskii wrote: >>>> Date: Fri, 08 Mar 2013 22:33:07 +0200 >>>> From: Eli Zaretskii >>>> Cc: 13907@debbugs.gnu.org >>>> >>>> And one more question: what is the value of file-name _before_ it is >>>> passed to cygwin-convert-file-name-from-windows? Does it perhaps >>>> already have the U-umlaut replaced by a blank? >>> >>> I think the problem is on the C level, not on the Lisp level. Take a >>> look at w32term.c:construct_drag_n_drop -- it uses ANSI version of >>> DragQueryFile to get the file name, then decodes it by DECODE_FILE. >>> But DECODE_FILE uses UTF-8 in the cygw32 build, so this is >>> inappropriate for decoding file names that come from Windows APIs. >>> >>> Instead, in the cygw32 build, construct_drag_n_drop should use >>> DragQueryFileW and convert the file name to the internal Emacs >>> representation using from_unicode. >>> >> >> >> Thanks for finding that! I've been swamped this week, and I haven't been able to >> do any investigation. I'll see whether I can come up with a fix this weekend. >> > > The patch below resolves the issue for me. Assuming it's acceptable, where > should I install it? It fixes it for me too. Thanks. Ken