From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alexander Shukaev Newsgroups: gmane.emacs.bugs Subject: bug#25189: Use `current-global-map' in `comint-insert-input' Date: Thu, 26 Dec 2019 01:32:00 +0100 Message-ID: <51389711-b5b8-0d62-b18b-beae57d61bca@Alexander.Shukaev.name> References: <7a0f388c-3678-cf59-5da6-11c532f4fcdd@Alexander.Shukaev.name> <875znnk96a.fsf@mouse.gnus.org> <45ae521c-6f37-292e-c169-9ed591cb0504@Alexander.Shukaev.name> <87k16l6689.fsf@gnus.org> <40a05d64-0907-6b83-6961-dd4a2c510d31@Alexander.Shukaev.name> <874kxo3x08.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="215544"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 25189@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 26 01:33:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ikH5V-000tvS-7V for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Dec 2019 01:33:13 +0100 Original-Received: from localhost ([::1]:50068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikH5U-0006pf-3h for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2019 19:33:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57445) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ikH5L-0006oH-3z for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 19:33:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ikH5K-0004jX-36 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 19:33:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48811) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ikH5J-0004jO-Vu for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 19:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ikH5J-0001u6-Rn for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2019 19:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Dec 2019 00:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 25189-submit@debbugs.gnu.org id=B25189.15773203257158 (code B ref 25189); Thu, 26 Dec 2019 00:33:01 +0000 Original-Received: (at 25189) by debbugs.gnu.org; 26 Dec 2019 00:32:05 +0000 Original-Received: from localhost ([127.0.0.1]:54784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikH4O-0001rN-Oa for submit@debbugs.gnu.org; Wed, 25 Dec 2019 19:32:04 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikH4M-0001qy-Sp for 25189@debbugs.gnu.org; Wed, 25 Dec 2019 19:32:03 -0500 X-Originating-IP: 178.4.8.44 Original-Received: from [192.168.3.109] (dslb-178-004-008-044.178.004.pools.vodafone-ip.de [178.4.8.44]) (Authenticated sender: forum@alexander.shukaev.name) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id EC1E840002; Thu, 26 Dec 2019 00:32:00 +0000 (UTC) In-Reply-To: <874kxo3x08.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173769 Archived-At: On 12/25/19 10:39 PM, Lars Ingebrigtsen wrote: > Alexander Shukaev writes: > >>> The value is a keymap that is usually (but not necessarily) Emacs’s >>> global map. >> >> So it's not necessarily the current global keymap. Hence, applying >> `define-key' (or any other mutating function to it), may not take any >> effect and do what is expected. It is safer to always use >> `current-global-map'. At least that is my understanding why there are >> special functions like `current-global-map' for accessing and >> `use-global-map' for assignment. > > I'm unable to read any such thing from the documentation (or usage) of > those functions. A handful of places use use-global-map to alter what > global map is in usage, and I see no indication that functions like > comint-insert-input would want to alter these other maps instead of > (the real) global-map. > There is no "real" global map. There is only one current global map, any that can be chosen by user at any point in time. Emacs is inconsistent in how it uses either `global-map' or `(current-global-map)' to assign key bindings. I would guess this is due to historical reasons of `current-global-map' appearing later than `global-map'. This is more of a call to review the Emacs code base and/or documentation with respect to this inconsistency in order to decide what is the conventional/consistent approach to bind keys to a global map as both have advantages and disadvantages.