From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: bidi_fetch_char Date: Thu, 07 Mar 2013 13:55:04 +0400 Message-ID: <513863F8.2040703@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362650125 27642 80.91.229.3 (7 Mar 2013 09:55:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Mar 2013 09:55:25 +0000 (UTC) Cc: Emacs development discussions To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 07 10:55:48 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UDXYA-0005k7-Fg for ged-emacs-devel@m.gmane.org; Thu, 07 Mar 2013 10:55:46 +0100 Original-Received: from localhost ([::1]:56924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXXo-0005OY-LK for ged-emacs-devel@m.gmane.org; Thu, 07 Mar 2013 04:55:24 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXXl-0005O8-Kk for emacs-devel@gnu.org; Thu, 07 Mar 2013 04:55:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDXXk-000313-N3 for emacs-devel@gnu.org; Thu, 07 Mar 2013 04:55:21 -0500 Original-Received: from forward10.mail.yandex.net ([77.88.61.49]:58165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDXXi-0002zE-Ix; Thu, 07 Mar 2013 04:55:18 -0500 Original-Received: from smtp6.mail.yandex.net (smtp6.mail.yandex.net [77.88.61.56]) by forward10.mail.yandex.net (Yandex) with ESMTP id 38D4210200F9; Thu, 7 Mar 2013 13:55:15 +0400 (MSK) Original-Received: from smtp6.mail.yandex.net (localhost [127.0.0.1]) by smtp6.mail.yandex.net (Yandex) with ESMTP id 086F41640223; Thu, 7 Mar 2013 13:55:11 +0400 (MSK) Original-Received: from unknown (unknown [118.143.64.134]) by smtp6.mail.yandex.net (nwsmtp/Yandex) with ESMTP id t5bmenLt-tAba2WN3; Thu, 7 Mar 2013 13:55:11 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1362650111; bh=km++x+qkXatyB/YCC1oerqi+O5//rXkoUWe0Er7oMt8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: Content-Type:Content-Transfer-Encoding; b=tPFd7ZcmVfcrGRtbWOYIGzyeTbjyrllVb0dDkcZ8JvvSzecb6BetGbL/Fml0R5B/5 T6nAYZbbnLQWHRXPdAHD8gD7ub9ikFoj/ihpn3Ks/h7rMDOBZShPBlJDdJ+31mTckv hokNryA4nTnrUeaRO8IH8Ieu7jAoCE7+FPwRHrvw= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 77.88.61.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157554 Archived-At: I have a long-standing style question for you too :-). Since a lot of functions (almost all markers-related, gap movement, some stuff from composite.c and even from bidi.c) expects character position first and byte position next, I would suggest to swap 1st and 2nd arguments of bidi_fetch_char just for the sake of common style. Dmitry