From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [24.3] possible build failure for list-system-processes on DragonFlyBSD Date: Tue, 05 Mar 2013 21:07:07 -0800 Organization: UCLA Computer Science Department Message-ID: <5136CEFB.7020203@cs.ucla.edu> References: <513294CE.5060101@cs.ucla.edu> <87a9qi687k.fsf@moo.wxcvbn.org> <87obeyeykk.fsf@moo.wxcvbn.org> <51362D1A.4040903@cs.ucla.edu> <61mwuhmvdc.fsf@fencepost.gnu.org> <51366A30.7000203@cs.ucla.edu> <87d2vdfpj1.fsf@moo.wxcvbn.org> <87y5e1dzyc.fsf_-_@moo.wxcvbn.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362546440 29917 80.91.229.3 (6 Mar 2013 05:07:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Mar 2013 05:07:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 06 06:07:44 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UD6Zs-0000p7-Ax for ged-emacs-devel@m.gmane.org; Wed, 06 Mar 2013 06:07:44 +0100 Original-Received: from localhost ([::1]:50287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD6ZW-0004x3-HL for ged-emacs-devel@m.gmane.org; Wed, 06 Mar 2013 00:07:22 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD6ZR-0004mr-Kl for emacs-devel@gnu.org; Wed, 06 Mar 2013 00:07:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UD6ZQ-0005CN-8a for emacs-devel@gnu.org; Wed, 06 Mar 2013 00:07:17 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:58719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD6ZQ-0005BR-09; Wed, 06 Mar 2013 00:07:16 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 91819A600B8; Tue, 5 Mar 2013 21:07:08 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sfZSb-5JJUSN; Tue, 5 Mar 2013 21:07:08 -0800 (PST) Original-Received: from [192.168.1.9] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 23CE3A6009C; Tue, 5 Mar 2013 21:07:08 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157544 Archived-At: On 03/05/2013 07:12 PM, Glenn Morris wrote: > AFAICS, it was tested on FreeBSD and Max OS X? > So yes, as far as I'm concerned it can be restricted to just those rather > than BSD_SYSTEM. >From what I can gather, the NetBSD problem will come up only in the next NetBSD release, as the current release should be OK; still, if nobody's tested it we're probably better off omitting it for now. How about the following patch? === modified file 'src/sysdep.c' --- src/sysdep.c 2013-03-05 21:56:36 +0000 +++ src/sysdep.c 2013-03-06 05:02:30 +0000 @@ -2647,12 +2647,12 @@ return proclist; } -#elif defined BSD_SYSTEM && !defined __OpenBSD__ && !defined __MirBSD__ +#elif defined DARWIN_OS || defined __FreeBSD__ Lisp_Object list_system_processes (void) { -#if defined DARWIN_OS || defined __NetBSD__ +#ifdef DARWIN_OS int mib[] = {CTL_KERN, KERN_PROC, KERN_PROC_ALL}; #else int mib[] = {CTL_KERN, KERN_PROC, KERN_PROC_PROC}; @@ -2678,7 +2678,7 @@ len /= sizeof (struct kinfo_proc); for (i = 0; i < len; i++) { -#if defined DARWIN_OS || defined __NetBSD__ +#ifdef DARWIN_OS proclist = Fcons (make_fixnum_or_float (procs[i].kp_proc.p_pid), proclist); #else proclist = Fcons (make_fixnum_or_float (procs[i].ki_pid), proclist);