From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [24.3] possible build failure for list-system-processes on DragonFlyBSD
Date: Tue, 05 Mar 2013 21:07:07 -0800 [thread overview]
Message-ID: <5136CEFB.7020203@cs.ucla.edu> (raw)
In-Reply-To: <sjwqtlkyqk.fsf@fencepost.gnu.org>
On 03/05/2013 07:12 PM, Glenn Morris wrote:
> AFAICS, it was tested on FreeBSD and Max OS X?
> So yes, as far as I'm concerned it can be restricted to just those rather
> than BSD_SYSTEM.
From what I can gather,
the NetBSD problem will come up only in the next NetBSD release, as
the current release should be OK; still, if nobody's tested it we're
probably better off omitting it for now.
How about the following patch?
=== modified file 'src/sysdep.c'
--- src/sysdep.c 2013-03-05 21:56:36 +0000
+++ src/sysdep.c 2013-03-06 05:02:30 +0000
@@ -2647,12 +2647,12 @@
return proclist;
}
-#elif defined BSD_SYSTEM && !defined __OpenBSD__ && !defined __MirBSD__
+#elif defined DARWIN_OS || defined __FreeBSD__
Lisp_Object
list_system_processes (void)
{
-#if defined DARWIN_OS || defined __NetBSD__
+#ifdef DARWIN_OS
int mib[] = {CTL_KERN, KERN_PROC, KERN_PROC_ALL};
#else
int mib[] = {CTL_KERN, KERN_PROC, KERN_PROC_PROC};
@@ -2678,7 +2678,7 @@
len /= sizeof (struct kinfo_proc);
for (i = 0; i < len; i++)
{
-#if defined DARWIN_OS || defined __NetBSD__
+#ifdef DARWIN_OS
proclist = Fcons (make_fixnum_or_float (procs[i].kp_proc.p_pid), proclist);
#else
proclist = Fcons (make_fixnum_or_float (procs[i].ki_pid), proclist);
next prev parent reply other threads:[~2013-03-06 5:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 23:00 emacs-24.2.93 build problems Nelson H. F. Beebe
2013-03-03 0:09 ` Paul Eggert
2013-03-04 20:34 ` Glenn Morris
2013-03-04 23:44 ` Jérémie Courrèges-Anglas
2013-03-05 3:47 ` Glenn Morris
2013-03-05 14:00 ` Jérémie Courrèges-Anglas
2013-03-05 14:52 ` emacs-24.2.93 build problems (on OpenBSD) Jérémie Courrèges-Anglas
2013-03-05 20:06 ` Glenn Morris
2013-03-05 17:06 ` emacs-24.2.93 build problems Glenn Morris
2013-03-05 17:24 ` list-system-processes on OpenBSD [was Re: emacs-24.2.93 build problems] Glenn Morris
2013-03-05 17:36 ` Paul Eggert
2013-03-05 20:42 ` list-system-processes on OpenBSD Glenn Morris
2013-03-05 21:57 ` Paul Eggert
2013-03-05 22:30 ` Jérémie Courrèges-Anglas
2013-03-06 0:38 ` [24.3] possible build failure for list-system-processes on NetBSD Jérémie Courrèges-Anglas
2013-03-06 2:28 ` [24.3] possible build failure for list-system-processes on DragonFlyBSD Jérémie Courrèges-Anglas
2013-03-06 3:12 ` Glenn Morris
2013-03-06 5:07 ` Paul Eggert [this message]
2013-03-06 7:30 ` Glenn Morris
2013-03-06 2:31 ` list-system-processes on OpenBSD [was Re: emacs-24.2.93 build problems] Leo Liu
2013-03-04 23:51 ` emacs-24.2.93 build problems Glenn Morris
2013-03-05 2:06 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5136CEFB.7020203@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.