From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: CHAR_TO_BYTE in bidi_resolve_explicit_1 Date: Tue, 05 Mar 2013 13:30:06 +0400 Message-ID: <5135BB1E.60202@yandex.ru> References: <513552F8.40405@yandex.ru> <83vc96sdve.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362475829 14291 80.91.229.3 (5 Mar 2013 09:30:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Mar 2013 09:30:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 05 10:30:52 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCoCu-0001Sh-6A for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 10:30:48 +0100 Original-Received: from localhost ([::1]:46196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCoCY-00033g-MU for ged-emacs-devel@m.gmane.org; Tue, 05 Mar 2013 04:30:26 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCoCW-00033Z-0N for emacs-devel@gnu.org; Tue, 05 Mar 2013 04:30:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCoCR-0008NX-Fb for emacs-devel@gnu.org; Tue, 05 Mar 2013 04:30:23 -0500 Original-Received: from forward3.mail.yandex.net ([2a02:6b8:0:602::3]:49833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCoCL-0008KN-HB; Tue, 05 Mar 2013 04:30:13 -0500 Original-Received: from smtp4.mail.yandex.net (smtp4.mail.yandex.net [77.88.46.104]) by forward3.mail.yandex.net (Yandex) with ESMTP id D0097B4084E; Tue, 5 Mar 2013 13:30:11 +0400 (MSK) Original-Received: from smtp4.mail.yandex.net (localhost [127.0.0.1]) by smtp4.mail.yandex.net (Yandex) with ESMTP id A3C615C0836; Tue, 5 Mar 2013 13:30:11 +0400 (MSK) Original-Received: from unknown (unknown [118.143.64.134]) by smtp4.mail.yandex.net (nwsmtp/Yandex) with ESMTP id U7BiTHo1-U9BW6M84; Tue, 5 Mar 2013 13:30:11 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1362475811; bh=lEFpqstMfRdZaSZl86rkkgvCIef8AZ4QVSopSDzGnFU=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Iwfh4Vmayr5lZh8NSXDjT28tIc5SIilUExNQS538tcKgJPix8lOk8kTM9gUjKNx9l YjiXU8rFCOVyvm7HXObclqZEGUWUfUdv5ek3PpZu6/YJqEwweylLbSz4Nzz1IlJOzl I7kumQcnCwclNDEl5Zkqb9ED42v+TqmyLQT5hvxs= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 In-Reply-To: <83vc96sdve.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a02:6b8:0:602::3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157525 Archived-At: On 03/05/2013 07:51 AM, Eli Zaretskii wrote: > We could use BEGV_BYTE when we limit charpos to BEGV, yes. But > otherwise, the call to CHAR_TO_BYTE is not redundant, because nothing > else makes sure bidi_it->charpos is synchronized with bidi_it->bytepos > when the display engine re-seats the display iterator. AFAICS reseat routines uses bidi_init_it to make sure that BIDI stuff is synced with the rest of redisplay, isn't it? > Did you see some evidence that the call to CHAR_TO_BYTE is redundant > in the general case? I just tried the patch from the previous e-mail in the very basic editing session against a few files (including Greek and R2L Arabic scripts), and eassert was never triggered. Dmitry