From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure' Date: Mon, 04 Mar 2013 21:26:30 -0800 Organization: UCLA Computer Science Department Message-ID: <51358206.2040407@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1362461267 23090 80.91.229.3 (5 Mar 2013 05:27:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Mar 2013 05:27:47 +0000 (UTC) To: 13872@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 05 06:28:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UCkQ7-0007YG-9J for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2013 06:28:11 +0100 Original-Received: from localhost ([::1]:54002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkPl-0007NW-2k for geb-bug-gnu-emacs@m.gmane.org; Tue, 05 Mar 2013 00:27:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkPh-0007LM-KU for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:27:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCkPg-0001XM-G8 for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:27:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkPg-0001XH-CR for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:27:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UCkPy-0003j2-LR for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Mar 2013 05:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13872 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136246122514248 (code B ref -1); Tue, 05 Mar 2013 05:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Mar 2013 05:27:05 +0000 Original-Received: from localhost ([127.0.0.1]:59550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCkP3-0003hl-7m for submit@debbugs.gnu.org; Tue, 05 Mar 2013 00:27:05 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34315) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UCkP0-0003hE-3Z for submit@debbugs.gnu.org; Tue, 05 Mar 2013 00:27:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCkOb-0001Qm-Er for submit@debbugs.gnu.org; Tue, 05 Mar 2013 00:26:38 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:35341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkOb-0001Qi-CI for submit@debbugs.gnu.org; Tue, 05 Mar 2013 00:26:37 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkOa-0007Ib-9q for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:26:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCkOZ-0001QS-07 for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:26:36 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:48900) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCkOY-0001QO-Q6 for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2013 00:26:34 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B190BA6006F for ; Mon, 4 Mar 2013 21:26:33 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26ymAOhlZxdN for ; Mon, 4 Mar 2013 21:26:31 -0800 (PST) Original-Received: from [192.168.1.9] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 6AA3DA60065 for ; Mon, 4 Mar 2013 21:26:30 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72102 Archived-At: Building Emacs 24.3-rc1 on Fedora 17 x86-64 generates a config.log with lots of these diagnostics: conftest.c:242:0: warning: "TERM_HEADER" redefined [enabled by default] conftest.c:71:0: note: this is the location of the previous definition The problem is that TERM_HEADER is put into conftest.c twice, with disagreeing definitions: #define TERM_HEADER "xterm.h" ... #define TERM_HEADER "gtkutil.h" On this platform it happens to work, but I worry that on other platforms the C compiler will reject any such test program (as it is entitled to do), which will cause later configuration decisions to go wrong. Here's a fix. This looks pretty safe. === modified file 'ChangeLog' --- ChangeLog 2013-03-05 03:43:52 +0000 +++ ChangeLog 2013-03-05 05:21:41 +0000 @@ -1,3 +1,8 @@ +2013-03-05 Paul Eggert + + * configure.ac (TERM_HEADER): Remove duplicate definition + that can mess up 'configure' runs. + 2013-03-05 Glenn Morris * Makefile.in (install-man): Ignore gzip exit status. === modified file 'configure.ac' --- configure.ac 2013-03-05 03:53:34 +0000 +++ configure.ac 2013-03-05 04:50:24 +0000 @@ -1646,11 +1646,6 @@ ;; esac -if test -n "${term_header}"; then - AC_DEFINE_UNQUOTED(TERM_HEADER, "${term_header}", - [Define to the header for the built-in window system.]) -fi - if test "$window_system" = none && test "X$with_x" != "Xno"; then AC_CHECK_PROG(HAVE_XSERVER, X, true, false) if test "$HAVE_XSERVER" = true ||