all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 13743@debbugs.gnu.org
Subject: bug#13743: 24.2.93; Segmentation fault when trying to [s]teal a file opened elsewhere
Date: Sun, 24 Feb 2013 19:28:32 +0400	[thread overview]
Message-ID: <512A31A0.4040804@yandex.ru> (raw)
In-Reply-To: <83621ilvk9.fsf@gnu.org>

On 23.02.2013 22:44, Eli Zaretskii wrote:
>>> I can fix this particular problem with this simple patch:
>> [...]
>>> However, I'm not sure this is the right or the best way.  If it is, it
>>> will probably be prudent to add some protection against infinite
>>> recursion here.
>>
>> How 'bout moving the
>>
>>     if (BUFFERP (object))
>>       modify_region (object, start, end);
>>
>> earlier in the function.  Something like the patch below.
>
> This will (falsely, AFAIU) tell us that the region is about to be
> modified when we return at the point marked below:

I tried the patches, and both seem to work fine so far. If you could 
explain the practical implications of the drawback in Stefan's patch 
you're describing here, I'll try to test for that, too.

>    /* If we're not starting on an interval boundary, we have to
>      split this interval.  */
>    if (i->position != s)
>      {
>        /* If this interval already has the properties, we can
>           skip it.  */
>        if (interval_has_all_properties (properties, i))
> 	{
> 	  ptrdiff_t got = (LENGTH (i) - (s - i->position));
> 	  if (got >= len)
> 	    RETURN_UNGCPRO (Qnil); <<<<<<<<<<<<<<<<<<<<<<<<<<<
> 	  len -= got;
> 	  i = next_interval (i);
> 	}
>        else
>






  reply	other threads:[~2013-02-24 15:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  6:41 bug#13743: 24.2.93; Segmentation fault when trying to [s]teal a file opened elsewhere Dmitry Gutov
2013-02-18 16:11 ` Eli Zaretskii
2013-02-19  0:52   ` Dmitry Gutov
2013-02-20 19:31     ` Eli Zaretskii
2013-02-21  8:30       ` Dmitry Gutov
2013-02-18 19:35 ` Glenn Morris
2013-02-19  0:55   ` Dmitry Gutov
2013-02-21  5:16 ` Paul Eggert
2013-02-21  7:03   ` Dmitry Gutov
2013-02-23  3:37   ` Dmitry Gutov
2013-02-23 15:10     ` Eli Zaretskii
2013-02-23 16:59       ` Stefan Monnier
2013-02-23 18:44         ` Eli Zaretskii
2013-02-24 15:28           ` Dmitry Gutov [this message]
2013-02-24 15:50             ` Eli Zaretskii
2013-02-25  5:52               ` Dmitry Gutov
2013-02-25 15:25                 ` Stefan Monnier
2013-02-25 16:37                   ` Eli Zaretskii
2013-02-25 18:29                     ` Stefan Monnier
2013-02-25 18:56                       ` Eli Zaretskii
2013-02-25 20:28                         ` Stefan Monnier
2013-02-26  3:39                           ` Eli Zaretskii
2013-02-26  4:35                             ` Stefan Monnier
2013-03-02  9:30                               ` Eli Zaretskii
2013-02-25 16:25                 ` Eli Zaretskii
2013-02-25 18:27                   ` Dmitry Gutov
2013-02-25 16:27                 ` Eli Zaretskii
2013-02-25 19:08                   ` Dmitry Gutov
2013-02-25 19:31                     ` Eli Zaretskii
2013-02-25 23:23                       ` Dmitry Gutov
2013-02-26  3:51                         ` Eli Zaretskii
2013-02-26  3:59                           ` Dmitry Gutov
2013-02-26 18:42                             ` Eli Zaretskii
2013-02-27 17:46                               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512A31A0.4040804@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=13743@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.