From: Paul Eggert <eggert@cs.ucla.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Bug in filelock.c
Date: Sat, 23 Feb 2013 16:25:16 -0800 [thread overview]
Message-ID: <51295DEC.1010808@cs.ucla.edu> (raw)
In-Reply-To: <m2vc9i4rpq.fsf@igel.home>
On 02/23/2013 01:59 PM, Andreas Schwab wrote:
> It worked perfectly well until about 8 months ago.
Thanks, I installed the following patch to the emacs-24 branch
and I assume this fix will propagate into the trunk.
I still don't see the need for that extra business with
using '.#FOO.1' as the lock file name if a file '.#FOO' happens
to exist and is not a symbolic link. How about if we remove
that stuff (in the trunk)? Isn't it a waste of a system call for
something nobody should need?
----
Fix regression introduced by July 10 filelock.c patch.
* filelock.c (fill_in_lock_file_name): Fix crash caused by the
2012-07-10 patch to this file. Reported by Eli Zaretskii in
<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00533.html>
and diagnosed by Andreas Schwab in
<http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00534.html>.
=== modified file 'src/filelock.c'
--- src/filelock.c 2013-01-01 09:11:05 +0000
+++ src/filelock.c 2013-02-24 00:16:45 +0000
@@ -316,7 +316,7 @@
p[1] = '.';
p[2] = '#';
- p = p + length + 2;
+ p = lockfile + length + 2;
while (lstat (lockfile, &st) == 0 && !S_ISLNK (st.st_mode))
{
next prev parent reply other threads:[~2013-02-24 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-23 19:07 Bug in filelock.c Eli Zaretskii
2013-02-23 19:39 ` Paul Eggert
2013-02-23 20:23 ` Eli Zaretskii
2013-02-23 21:59 ` Andreas Schwab
2013-02-24 0:25 ` Paul Eggert [this message]
2013-02-24 3:46 ` Eli Zaretskii
2013-02-24 7:30 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51295DEC.1010808@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.