all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Fabián Ezequiel Gallina" <fabian@anue.biz>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed
Date: Wed, 20 Feb 2013 17:54:59 -0300	[thread overview]
Message-ID: <51253823.1000601@anue.biz> (raw)
In-Reply-To: <jwva9qz3xce.fsf-monnier+emacs@gnu.org>

On 02/20/2013 11:01 AM, Stefan Monnier wrote:
>> FWIW this very small change corrected the python-info-current-defun behavior
>> and was able to pass the test suite I've been working on.
> I don't doubt it works, I'm just pointing out that it would be better to
> place the save-match-data elsewhere.  The general rule is: put the
> save-match-data between the "match" and the corresponding "get
> match-data" rather than around some code that might modify the match-data.
Thanks for the clarification, I pushed a change for this in revno 111284.
>> So far my local test/automated/python-tests.el is covering
>> indentation, movement and python-info-* functions completely.  Would it
>> be OK to introduce these tests into the emacs-24 branch?
> Yes, it's OK to add files to emacs-24/test/...
Pushed in revno 111283.
>> In this regard, I have a change in the works that will cause python.el to
>> stop messing with match-data so much (use of looking-at-p instead of
>> looking-at and such), and document those functions that are intended to.
>> If everyone agrees I could get this to the emacs-24 branch.
> I generally recommend not to go down that route.  Instead, just make sure
> all the match-{beginning/end/string} calls come right after the
> corresponding search, and if not, place a save-match-data around the
> intermediate code.

That's good, I will not get picky about match-data modification. In any 
case these replacements of looking-at and string-match are part of a set 
of good and fairly cheap refactors (partially based on 
https://github.com/fgallina/python.el/pull/121).



Thanks,
Fabián



      reply	other threads:[~2013-02-20 20:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1U7sgy-00020G-Up@vcs.savannah.gnu.org>
2013-02-19 21:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed Stefan Monnier
2013-02-20  5:24   ` Fabián Ezequiel Gallina
2013-02-20 14:01     ` Stefan Monnier
2013-02-20 20:54       ` Fabián Ezequiel Gallina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51253823.1000601@anue.biz \
    --to=fabian@anue.biz \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.