From: "Fabián Ezequiel Gallina" <fabian@anue.biz>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed
Date: Wed, 20 Feb 2013 02:24:31 -0300 [thread overview]
Message-ID: <51245E0F.6080603@anue.biz> (raw)
In-Reply-To: <jwvfw0s9eaa.fsf-monnier+emacs@gnu.org>
On 02/19/2013 06:37 PM, Stefan Monnier wrote:
>> - (python-nav-end-of-defun)
>> + (save-match-data
>> + ;; FIXME: avoid cluttering match-data
>> + ;; where's not wanted.
>> + (python-nav-end-of-defun))
>> (+ (point)
>> (if (>= (current-indentation) min-indent)
>> (1+ (current-indentation))
> I suspect this is not The Right Place for the save-match-data, since we
> should not assume that current-indentation won't also mess up the
> match-data.
>
>
> Stefan
FWIW this very small change corrected the python-info-current-defun
behavior and was able to pass the test suite I've been working on. So
far my local test/automated/python-tests.el is covering indentation,
movement and python-info-* functions completely. Would it be OK to
introduce these tests into the emacs-24 branch?
Now, I certainly wasn't expecting current-indentation could change
match-data (could it?). If so, I feel that functions not expected[0] to
mess with match-data should at least document it.
In this regard, I have a change in the works that will cause python.el
to stop messing with match-data so much (use of looking-at-p instead of
looking-at and such), and document those functions that are intended to.
If everyone agrees I could get this to the emacs-24 branch.
[0] By "functions not expected[0] to mess with match-data" I mean
functions that are not receiving a regexp as argument.
Regards,
Fabián
next prev parent reply other threads:[~2013-02-20 5:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1U7sgy-00020G-Up@vcs.savannah.gnu.org>
2013-02-19 21:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111281: * progmodes/python.el (python-info-current-defun): Fix failed Stefan Monnier
2013-02-20 5:24 ` Fabián Ezequiel Gallina [this message]
2013-02-20 14:01 ` Stefan Monnier
2013-02-20 20:54 ` Fabián Ezequiel Gallina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51245E0F.6080603@anue.biz \
--to=fabian@anue.biz \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.