Can I move trunk revision 111670?

Can I move trunk revision 111670?

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

111670 unbreaks daemon mode under cygw32. The change is simply this:

=== modified file 'src/emacs.c'
--- src/emacs.c	2013-02-02 17:14:24 +0000
+++ src/emacs.c	2013-02-03 16:34:57 +0000
@@ -1059,7 +1059,7 @@

             argv[skip_args] = fdStr;

-            execv (argv[0], argv);
+            execvp (argv[0], argv);
             fprintf (stderr, "emacs daemon: exec failed: %d\n", errno);
             exit (1);
           }

Can I move it to the release branch?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: Can I move trunk revision 111670?

[Glenn Morris]

Daniel Colascione wrote:

> -            execv (argv[0], argv);
> +            execvp (argv[0], argv);

Why does cygw32 needs this, but plain cygwin and every other platform
(apparently) not?

> Can I move it to the release branch?

As always, it would have been better to install it there in the first
place, if that turns out to be where it needs to be.

Re: Can I move trunk revision 111670?

[Daniel Colascione]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On 2/3/13 5:58 PM, Glenn Morris wrote:
> Daniel Colascione wrote:
> 
>> -            execv (argv[0], argv);
>> +            execvp (argv[0], argv);
> 
> Why does cygw32 needs this, but plain cygwin and every other platform
> (apparently) not?

Cygw32 and the NS toolkit both require that Emacs exec after fork if
the child is to use any GUI code. NS has the same bug; I just
imagine that relative few people handle it because argv[0] happens
to more often be an absolute path there.

> 
>> Can I move it to the release branch?
> 
> As always, it would have been better to install it there in the first
> place, 


> if that turns out to be where it needs to be.

Sure, but I wanted to make the fix available in the trunk first
regardless of whether it was being moved for




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 235 bytes --]

Re: Can I move trunk revision 111670?

[Glenn Morris]

Daniel Colascione wrote:

> Cygw32 and the NS toolkit both require that Emacs exec after fork if
> the child is to use any GUI code. NS has the same bug; I just
> imagine that relative few people handle it because argv[0] happens
> to more often be an absolute path there.

Ah, I missed that this code branch is only used on a few platforms.
Yes, please backport it.