From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#13399: 24.3.50; Word-wrap can't wrap at zero-width space U-200B Date: Sat, 02 Feb 2013 19:20:44 +0100 Message-ID: <510D58FC.2030605@gmx.at> References: <50EE7BE5.2060806@gmx.at> <83hamohmtj.fsf@gnu.org> <50EFCA6D.7090702@gmx.at> <83ip74ume7.fsf@gnu.org> <50EFE99A.5070508@gmx.at> <838v80ugv1.fsf@gnu.org> <50F021EC.4040107@gmx.at> <50F054A0.2040606@gmx.at> <83libztt68.fsf@gnu.org> <83hammu7og.fsf@gnu.org> <510D436A.1000603@gmx.at> <83a9rmbo30.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1359829335 28134 80.91.229.3 (2 Feb 2013 18:22:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Feb 2013 18:22:15 +0000 (UTC) Cc: 13399@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 02 19:22:35 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U1hjW-0002yi-Dg for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2013 19:22:34 +0100 Original-Received: from localhost ([::1]:48660 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1hjE-0007fU-23 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Feb 2013 13:22:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1hjA-0007f9-BA for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 13:22:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U1hj5-0006O1-ER for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 13:22:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U1hj5-0006Nw-Bq for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 13:22:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U1hjx-0007pC-Rc for bug-gnu-emacs@gnu.org; Sat, 02 Feb 2013 13:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Feb 2013 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13399 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13399-submit@debbugs.gnu.org id=B13399.135982932229950 (code B ref 13399); Sat, 02 Feb 2013 18:23:01 +0000 Original-Received: (at 13399) by debbugs.gnu.org; 2 Feb 2013 18:22:02 +0000 Original-Received: from localhost ([127.0.0.1]:33147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1hj0-0007n0-6L for submit@debbugs.gnu.org; Sat, 02 Feb 2013 13:22:02 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:65227) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U1hik-0007m2-Vy for 13399@debbugs.gnu.org; Sat, 02 Feb 2013 13:22:00 -0500 Original-Received: from mailout-de.gmx.net ([10.1.76.27]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MAiu5-1U8bbU11Tf-00BwLa for <13399@debbugs.gnu.org>; Sat, 02 Feb 2013 19:20:51 +0100 Original-Received: (qmail invoked by alias); 02 Feb 2013 18:20:51 -0000 Original-Received: from 62-47-50-198.adsl.highway.telekom.at (EHLO [62.47.50.198]) [62.47.50.198] by mail.gmx.net (mp027) with SMTP; 02 Feb 2013 19:20:51 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19JHQ9y/kpJuRb+Rhb+tjipC3XtmbKJdMvyZAbjCB TsxwaAmcNc4khT In-Reply-To: <83a9rmbo30.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70613 Archived-At: >> + /* Maximum x pixel position encountered within a display line. */ >> + int max_current_x; > > Adding a struct member for the sake of just one user sounds > unjustified. Can we instead make move_it_to accumulate the value > internally and return it? I don't know. IIUC most iterator functions never return something useful. And if one wants to glue together the results of subsequent calls of move_it_to, it might make sense to not reset the value internally. > In any case, the comment is inaccurate, since the value is accumulated > across all the display lines traversed by the iterator, not computed > per display line. Would "within any line traversed by the iterator" be better? >> +DEFUN ("window-buffer-pixel-size", Fwindow_buffer_pixel_size, Swindow_buffer_pixel_size, 0, 5, 0, > > Why not window-text-pixel-size? The "buffer" part doesn't belong > here, I think. Since I also look at buffer portions outside the window, such a term wouldn't be very accurate either. > "Lines starting below Y_LIMIT" is ambiguous. I suggest > > Lines whose y-coordinate is beyond Y_LIMIT will not be scanned. OK. >> +Since calculating the pixel-height of a large buffer can take some time, >> +it makes sense to specify this argument if the size of the buffer is >> +unknown. */) > > The doc string keeps silent about arguments FROM and TO. ... because I only added them later on ;-) Initially I always scanned from `point-min' to min (`point-max', y_limit) but later I noticed that with side-by-side windows it makes sense to start at `window-start'. >> + /* Actually, we never want move_it_to stop at to_x. But to make sure >> + that move_it_in_display_line_to always moves far enough, we set it >> + to MOST_POSITIVE_FIXNUM and specify MOVE_TO_X. */ >> + move_it_to (&it, end, MOST_POSITIVE_FIXNUM, max_y, -1, >> + MOVE_TO_POS | MOVE_TO_X | MOVE_TO_Y); > > Did you test what this does when END is covered by a display string? No. I didn't try invisible text and other atrocities either. In fact, I never experimented with a non-ZV end position so far. Which problems do you see? martin