From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Fri, 8 Sep 2023 21:38:02 +0300 Message-ID: <50f3f526-d0af-4f9a-b83e-ef7d41374dac@gutov.dev> References: <83fs4f36wi.fsf@gnu.org> <1b963d24-51b3-8128-ad14-e4af2c9f0c43@gutov.dev> <83ledhxk5c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4407"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Eli Zaretskii , monnier@iro.umontreal.ca, philipk@posteo.net, emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 08 20:38:24 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qegN5-0000tR-9d for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Sep 2023 20:38:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qegMs-0002LH-1d; Fri, 08 Sep 2023 14:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qegMq-0002Kp-BQ for emacs-devel@gnu.org; Fri, 08 Sep 2023 14:38:08 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qegMo-0001KR-AA; Fri, 08 Sep 2023 14:38:08 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E8F2B5C00A9; Fri, 8 Sep 2023 14:38:04 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 08 Sep 2023 14:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1694198284; x=1694284684; bh=Ft4rZDripu1/Ht93PIMneFp1di6VlaHKSgI XGfrF5+Q=; b=Fy6pKc8MJhAnEr5tvURWEQ912AolhfesMERe5NkJIwYXFBDd2pc isDW9AajodbBfZfz1JOUC+yJXOHz90X8jvBNmCCew3snqMZRc68qujHtsLOSo8uX vYyR3TqB2rISTznI9iRjwnD+CQwHf37p0KThm0xh7KjqlYtWUYgCu9zTjxU1KRx2 TlwLCYs/c536Ef/gQz/nGgvmoAlQZq1nqPmo3FU8PRjTkarp2THu6aHua/Xg7x9D rpWPDaNjenj6WyLgzicwgrPgkXKqnaXs42DS+6Y2FrQjSE7oWyw9U5I+OdUQSGWh 0PgYz3lRDQ/BXxLxwjGNtDzdl9MJMvlAUkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1694198284; x=1694284684; bh=Ft4rZDripu1/Ht93PIMneFp1di6VlaHKSgI XGfrF5+Q=; b=R+LtlR1qw5TTdLRQEETEaoVXH+AD+epbKMNRFNGCRe9GJV1pRFv fvad2iqYTFjLWLSxex2HciJcbCdjn/iRqi1ZeWTDfCr0ol8+rTZYSnD7xfYmUlUA tFe4JWh0RSN/1vyvAMjQFVuWi7XC++MCpqlNoudKMBh+voQSoq8m53YCQUnaHKP2 +lfUDDcjy20oJCuWwZIfYRfgdJghgqq1zBdx5VpT6z7ZH5MHOrADfrtJZrzXOusg 9BLCgObFwO79pyksc9/E2+KUS4TSYhFpdLBk1Ojjar7gOGfs4a+9KCmUmcprA76m TunwYQFnieyv+8msiS2ZFhfMpCzgu+hissQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehjedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffg feejheenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Sep 2023 14:38:03 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=66.111.4.26; envelope-from=dmitry@gutov.dev; helo=out2-smtp.messagingengine.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.473, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310357 Archived-At: On 08/09/2023 21:35, João Távora wrote: > On Fri, Sep 8, 2023 at 7:25 PM Dmitry Gutov wrote: > >> That seems to rhyme with my proposal. Except instead of "done editing" >> it will be "done reviewing" (though some rare users might engage in >> editing the diff as well). > It doesn't rhyme at all, unless you really twist your ears. > > What's wrong with C-c RET, easily typed ad as C-c C-m? Or > just RET, for that matter? RET is already taken. C-c RET is not as discoverable and doesn't match any other mode. > Also why should a discussion on refactoring capabilities have > to kick off with the proposal for the destruction of one of > the most longstanding useful shortcuts in diff-mode? Because we have now a feature which uses diff-mode for confirming a refactoring? Anyway, I don't understand the strength of your reaction, but I'm not going to push this.