From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: 24.2.92 fix [Re: Crash caused by insert-file-contents, both trunk (bzr 111532) and 24.2.92 affected] Date: Tue, 22 Jan 2013 08:48:19 +0400 Message-ID: <50FE1A13.8040903@yandex.ru> References: <50F52EC0.2030309@yandex.ru> <8338y2qsyi.fsf@gnu.org> <50F593E8.2030105@yandex.ru> <83vcay8g2n.fsf@gnu.org> <50F830F6.1070805@yandex.ru> <83pq137l6o.fsf@gnu.org> <50F83F08.1060709@yandex.ru> <83pq125lq5.fsf@gnu.org> <50FD0268.5000602@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1358830115 17291 80.91.229.3 (22 Jan 2013 04:48:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2013 04:48:35 +0000 (UTC) Cc: Eli Zaretskii , Chong Yidong , Emacs development discussions To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 22 05:48:53 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TxVmz-00025F-Kl for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2013 05:48:49 +0100 Original-Received: from localhost ([::1]:57389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxVmi-0008V8-DE for ged-emacs-devel@m.gmane.org; Mon, 21 Jan 2013 23:48:32 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxVmf-0008U0-TX for emacs-devel@gnu.org; Mon, 21 Jan 2013 23:48:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TxVme-0005TE-IC for emacs-devel@gnu.org; Mon, 21 Jan 2013 23:48:29 -0500 Original-Received: from forward4.mail.yandex.net ([77.88.46.9]:34654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TxVma-0005Rt-Pg; Mon, 21 Jan 2013 23:48:25 -0500 Original-Received: from smtp3.mail.yandex.net (smtp3.mail.yandex.net [77.88.46.103]) by forward4.mail.yandex.net (Yandex) with ESMTP id CA6E71BC24AB; Tue, 22 Jan 2013 08:48:20 +0400 (MSK) Original-Received: from smtp3.mail.yandex.net (localhost [127.0.0.1]) by smtp3.mail.yandex.net (Yandex) with ESMTP id 7B97B1BA0830; Tue, 22 Jan 2013 08:48:20 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp3.mail.yandex.net (nwsmtp/Yandex) with ESMTP id mJqiajNq-mKqKAHPN; Tue, 22 Jan 2013 08:48:20 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1358830100; bh=y1RP8Yd9r13ojrVqaexig5FOORxhx3/Zxyh/Bu08d64=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=buLx0WbprPS/1FZ3qYffpjlLzBLX/F0TOytMskSLSqvEQNg63e2fxWPWOH+ik5WfB bmbniWptp8pb9JMBkHhJtoikKzp0AtJcoeCVPqzflIW6oTv98oHHosFXCYmJtk9Y5V p+gxoYNX7AR/qz3McpfAbdV0TdW5ahnPnzK1oPmU= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] [fuzzy] X-Received-From: 77.88.46.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156571 Archived-At: On 01/22/2013 05:54 AM, Glenn Morris wrote: > Sorry, I missed the context. > What problem is this fixing? Crash caused by insert-file-contents from non-regular file (http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00324.html and below in thread). > How is it triggered? On GNU/Linux, (insert-file-contents "XXX") where XXX is a character or block device file (/dev/kmsg, /dev/sda, whatever else). > What version of Emacs did the problem first appear in? I found that both in 24.2.92 and trunk bzr 111532, and suspect a long-standing bug from 2001 or so. > How safe do you think the fix is? I did a quite representative testing against a few character and block devices found on my system, and the crash is gone. So I consider it as good enough until otherwise proved :-). Dmitry