bug#10753: 24.0.50; Vc-rcs under Windows does not make buffer or file read-only when file is checked in

bug#10753: 24.0.50; Vc-rcs under Windows does not make buffer or file read-only when file is checked in

[Mathias Dahl]

C-x C-f c:/test.txt RET
type some data and save with C-x C-s
C-x v v
Chose RCS as backend.
Notice that the buffer is not read-only, and the same goes for the file.

This is dangerous since I by mistake started to edit a file, thinking it
was checked out. When I then did C-x v v RCS checked out the previous
version on top of my working files, overwriting all my changes.

Thanks!

/Mathias

In GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600)
 of 2010-06-08 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 6.1.7600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: SVE
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> C-x C-f <C-backspace> <C-backspace> m d 
<tab> p g m <tab> a p a <tab> <tab> t o <tab> w e <tab> 
d e v <tab> <return> <down> <return> <return> <return> 
C-x v v <tab> R C S <return> <return> <down> C-x k 
<return> <return> C-x k <return> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <se
nd-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list... [2 times]
arg c:/MDAHSE/pgm/apache-tomcat-5.5.26/webapps/devtools/WEB-INF/classes/
arg ./
arg ../
arg devtools.clj
Registering (c:/MDAHSE/pgm/apache-tomcat-5.5.26/webapps/devtools/WEB-INF/classes/devtools.clj)... done

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message rfc822 mml mml-sec mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug
vc-arch vc-mtn vc-hg vc-git vc-bzr sha1 hex-util vc-sccs vc-svn vc-cvs
vc-rcs vc vc-dispatcher dired regexp-opt help-mode easymenu view tooltip
ediff-hook vc-hooks lisp-float-type mwheel dos-w32 disp-table ls-lisp
w32-win w32-vars tool-bar dnd fontset image fringe lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev button minibuffer
faces cus-face files text-properties overlay md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
make-network-process multi-tty emacs)
------------------------------------------------------------------------------

CONFIDENTIALITY AND DISCLAIMER NOTICE

This e-mail, including any attachments, is confidential and for use only by
the intended recipient. If you are not the intended recipient, please notify
us immediately and delete this e-mail from your system. Any use or disclosure
of the information contained herein is strictly prohibited. As internet
communications are not secure, we do not accept legal responsibility for the
contents of this message nor responsibility for any change made to this
message after it was sent by the original sender. We advise you to carry out
your own virus check as we cannot accept liability for damage resulting from
software viruses.

bug#10753: 24.0.50; Vc-rcs under Windows does not make buffer or file read-only when file is checked in

[Glenn Morris]

Mathias Dahl wrote:

> C-x C-f c:/test.txt RET
> type some data and save with C-x C-s
> C-x v v
> Chose RCS as backend.
> Notice that the buffer is not read-only, and the same goes for the file.

It works for me with the current trunk under GNU/Linux.
Either this is MS Windows-specific, or...

> In GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600)
>  of 2010-06-08 on 3249CTO

... that is fairly old. Please try the latest 24.0.9x pretest from

alpha.gnu.org/gnu/emacs/pretest/windows/

bug#10753: 24.0.50; Vc-rcs under Windows does not make buffer or file read-only when file is checked in

[Eli Zaretskii]

> From: Mathias Dahl <mathias.dahl@ifsworld.com>
> Date: Tue, 7 Feb 2012 11:40:13 +0100
> 
> C-x C-f c:/test.txt RET
> type some data and save with C-x C-s
> C-x v v
> Chose RCS as backend.
> Notice that the buffer is not read-only, and the same goes for the file.
> 
> This is dangerous since I by mistake started to edit a file, thinking it
> was checked out. When I then did C-x v v RCS checked out the previous
> version on top of my working files, overwriting all my changes.

This rings a bell.  Please see if this is not a duplicate of 8924.
You can find the RCS binaries I mentioned there on this page:

  http://sourceforge.net/projects/ezwinports/files/

bug#10753: 24.0.50; Vc-rcs under Windows does not make buffer or file read-only when file is checked in

[Mathias Dahl]

> It works for me with the current trunk under GNU/Linux.
> Either this is MS Windows-specific, or...

It works for me on Ubuntu GNU/Linux as well. I have tried to debug it and I haven't 
been able to arrive at a conclusion (hence this bug report) myself, but I am pretty
sure it has to do with the fact that it runs under Windows. For some reason, vs-rcs
is not able to set the file read-only after a check in or "register file" operation, like
under GNU/Linux.

I think one of the more experienced Emacs developers who has access to Windows
Will be able to recreate and find the cause quite easily. For me, vs-rcs is a bit to...
messy to understand.

>... that is fairly old. Please try the latest 24.0.9x pretest from

Sorry for that. I do use a newer version but I happened to use the older version
for reporting the bug. I have the same problem with the pretest from the middle of
January.

Thanks for the prompt reply!

/Mathias

------------------------------------------------------------------------------

CONFIDENTIALITY AND DISCLAIMER NOTICE

This e-mail, including any attachments, is confidential and for use only by
the intended recipient. If you are not the intended recipient, please notify
us immediately and delete this e-mail from your system. Any use or disclosure
of the information contained herein is strictly prohibited. As internet
communications are not secure, we do not accept legal responsibility for the
contents of this message nor responsibility for any change made to this
message after it was sent by the original sender. We advise you to carry out
your own virus check as we cannot accept liability for damage resulting from
software viruses.

bug#10753: Eli's hunch was correct

[Mathias Dahl]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

Eli's hunch was correct, it had to do with the RCS tool I used, which was from Cygwin. I installed the binaries Eli pointed to and made sure those were found earlier in the PATH and not it seems to work.

Also, I was a bit embarrassed when I understood that RCS was not an internal tool in Emacs... I don't know why, but I got the impression that Emacs was handling the RCS stuff internally, so I never suspected that there would be external tools.

Thanks!

/Mathias


------------------------------------------------------------------------------

CONFIDENTIALITY AND DISCLAIMER NOTICE

This e-mail, including any attachments, is confidential and for use only by
the intended recipient. If you are not the intended recipient, please notify
us immediately and delete this e-mail from your system. Any use or disclosure
of the information contained herein is strictly prohibited. As internet
communications are not secure, we do not accept legal responsibility for the
contents of this message nor responsibility for any change made to this
message after it was sent by the original sender. We advise you to carry out
your own virus check as we cannot accept liability for damage resulting from
software viruses.
\r

[-- Attachment #2: Type: text/html, Size: 5926 bytes --]