bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection

bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection

[Kim F. Storm]

The following change is just SO annoying.
I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the files that need attention -- but with this change,
it is practically random what is kept and what is removed.

2012-09-30  Stefan Monnier  <monnier@iro.umontreal.ca>

	* vc/pcvs.el (cvs-cleanup-collection): Keep entries that are currently
	visited in a buffer.

Could we at least have it as an option, -- thank you.


In GNU Emacs 24.2.91.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2013-01-02 on kfs-lx2
Windowing system distributor `The X.Org Foundation', version 11.0.11104000
System Description:	Debian GNU/Linux 6.0.6 (squeeze)

-- 
Kim F. Storm  <storm@cua.dk>      http://www.cua.dk

bug#13380: Acknowledgement (24.2.91; Annoying change to cvs-cleanup-collection)

[Kim Storm]

Of course, what I meant was

I'm accustomed to using 'x' in the *cvs* buffer to get rid of
all the entries that _DON'T_ need attention -- but with this change,
it is practically random what is kept and what is removed.


Kim

bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection

[Stefan Monnier]

> The following change is just SO annoying.
> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
> all the files that need attention -- but with this change,
> it is practically random what is kept and what is removed.

Oh, it was not meant to affect `x', indeed.  I just installed the patch
below which should fix it.


        Stefan


=== modified file 'lisp/vc/pcvs.el'
--- lisp/vc/pcvs.el	2013-01-01 09:11:05 +0000
+++ lisp/vc/pcvs.el	2013-01-08 17:29:57 +0000
@@ -876,9 +876,10 @@
 		     (`DEAD nil)
 		     ;; handled also?
 		     (`UP-TO-DATE
+                      (not
                       (if (find-buffer-visiting (cvs-fileinfo->full-name fi))
-                          t
-                        (not rm-handled)))
+                           (eq rm-handled 'all)
+                         rm-handled)))
 		     ;; keep the rest
 		     (_ (not (run-hook-with-args-until-success
 			      'cvs-cleanup-functions fi))))))
@@ -2121,7 +2122,7 @@
 Empty directories are removed."
   (interactive)
   (cvs-cleanup-collection cvs-cookies
-			  t (or cvs-auto-remove-directories 'handled) t))
+			  'all (or cvs-auto-remove-directories 'handled) t))
 
 
 (defun-cvs-mode cvs-mode-acknowledge ()

bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection

[Kim Storm]

On 2013-01-08 18:36, Stefan Monnier wrote:
>> The following change is just SO annoying.
>> I'm accustomed to using 'x' in the *cvs* buffer to get rid of
>> all the files that need attention -- but with this change,
>> it is practically random what is kept and what is removed.
> Oh, it was not meant to affect `x', indeed.  I just installed the patch
> below which should fix it.
>


Yes, that fixes it.

Thank you

Kim

bug#13380: 24.2.91; Annoying change to cvs-cleanup-collection

[Stefan Monnier]

> Yes, that fixes it.
> Thank you

Great, thanks, closing,


        Stefan "we're missing you here"