From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#13066: 24.2.90; setting rmail-summary-window-size causes error Date: Sun, 30 Dec 2012 10:28:42 +0100 Message-ID: <50E0094A.1010500@gmx.at> References: <87mwww9bq7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1356859743 30534 80.91.229.3 (30 Dec 2012 09:29:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Dec 2012 09:29:03 +0000 (UTC) Cc: 13066@debbugs.gnu.org To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 30 10:29:19 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TpFCo-0001wz-H4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Dec 2012 10:29:18 +0100 Original-Received: from localhost ([::1]:40232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpFCZ-0000Q7-NT for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Dec 2012 04:29:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:32897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpFCW-0000Q2-Or for bug-gnu-emacs@gnu.org; Sun, 30 Dec 2012 04:29:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TpFCV-0004Eu-Kr for bug-gnu-emacs@gnu.org; Sun, 30 Dec 2012 04:29:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TpFCV-0004Eo-HZ for bug-gnu-emacs@gnu.org; Sun, 30 Dec 2012 04:28:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TpFDW-0003ay-41 for bug-gnu-emacs@gnu.org; Sun, 30 Dec 2012 04:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Dec 2012 09:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13066-submit@debbugs.gnu.org id=B13066.135685979713787 (code B ref 13066); Sun, 30 Dec 2012 09:30:02 +0000 Original-Received: (at 13066) by debbugs.gnu.org; 30 Dec 2012 09:29:57 +0000 Original-Received: from localhost ([127.0.0.1]:36649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TpFDQ-0003aK-WB for submit@debbugs.gnu.org; Sun, 30 Dec 2012 04:29:57 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:62355) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TpFDO-0003aB-Po for 13066@debbugs.gnu.org; Sun, 30 Dec 2012 04:29:55 -0500 Original-Received: from mailout-de.gmx.net ([10.1.76.28]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0M3xZE-1SzCqG2Sck-00ragX for <13066@debbugs.gnu.org>; Sun, 30 Dec 2012 10:28:50 +0100 Original-Received: (qmail invoked by alias); 30 Dec 2012 09:28:50 -0000 Original-Received: from 62-47-61-197.adsl.highway.telekom.at (EHLO [62.47.61.197]) [62.47.61.197] by mail.gmx.net (mp028) with SMTP; 30 Dec 2012 10:28:50 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19M/Xwa2fZM6aE0DEVRiYiWUCg6KLPAuLspmPWT5N P4fpS9qIeo3L0Q In-Reply-To: <87mwww9bq7.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69186 Archived-At: > It seems that the new code changed the logic. Now > rmail-summary-window-size doesn't take effect. As I didn't > customize rmail-redisplay-summary, its value is nil. And > the new code handles rmail-summary-window-size only if its > value is non-nil. > > (and rmail-summary-buffer (buffer-name rmail-summary-buffer) > rmail-redisplay-summary ;; <--- !!! > (setq window > (display-buffer > rmail-summary-buffer '(nil (reusable-frames . visible)))) > rmail-summary-window-size > (setq size (- rmail-summary-window-size (window-height window))) > (window--resizable-p window size) > (window-resize window size)))) I obviously have no idea how this is supposed to work :-( We could replace the condition (when (and rmail-summary-buffer (buffer-name rmail-summary-buffer) rmail-redisplay-summary) in `rmail-maybe-display-summary' either by (when (and rmail-summary-buffer (buffer-name rmail-summary-buffer) (or rmail-redisplay-summary (get-buffer-window rmail-summary-buffer 0))) or by (when (and rmail-summary-buffer (buffer-name rmail-summary-buffer) (or rmail-redisplay-summary rmail-summary-window-size)) Both should work if the summary window was specially created for the summary. They won't work when the window got merely reused - but in that case resizing the window doesn't strike me as a good idea in the first place. Can you try them? If this doesn't help, can you please tell me when and why you want to resize the summary window and why you want to do that with `rmail-redisplay-summary' set to nil? I can obviously restore the old logic but would like to understand it first. Thanks, martin