From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#12993: Wrong icon for Cygw32-Emacs Date: Mon, 10 Dec 2012 13:05:40 -0800 Message-ID: <50C64EA4.1070303@dancol.org> References: <50B2300C.3090100@alice.it> <50C58B9F.8050105@dancol.org> <83lid6auv1.fsf@gnu.org> <83k3sqatks.fsf@gnu.org> <50C60CBE.1070905@dancol.org> <831uexbrz0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig297DACCECA62E4AED09D8CEB" X-Trace: ger.gmane.org 1355173590 22363 80.91.229.3 (10 Dec 2012 21:06:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2012 21:06:30 +0000 (UTC) Cc: 12993@debbugs.gnu.org, angelo.graziosi@alice.it To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 10 22:06:43 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TiAYk-0000iv-GO for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 22:06:42 +0100 Original-Received: from localhost ([::1]:48890 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiAYX-0001Uv-Uu for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2012 16:06:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiAYU-0001UV-04 for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 16:06:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiAYS-0000DW-Um for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 16:06:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiAYS-0000DR-Ro for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 16:06:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TiAZ3-0005oo-Pj for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2012 16:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Dec 2012 21:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12993-submit@debbugs.gnu.org id=B12993.135517359122324 (code B ref 12993); Mon, 10 Dec 2012 21:07:01 +0000 Original-Received: (at 12993) by debbugs.gnu.org; 10 Dec 2012 21:06:31 +0000 Original-Received: from localhost ([127.0.0.1]:35934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TiAYZ-0005o1-2E for submit@debbugs.gnu.org; Mon, 10 Dec 2012 16:06:31 -0500 Original-Received: from dancol.org ([96.126.100.184]:42234) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TiAYW-0005nt-AG for 12993@debbugs.gnu.org; Mon, 10 Dec 2012 16:06:29 -0500 Original-Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[0.0.0.0]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1TiAXt-0001LX-N3; Mon, 10 Dec 2012 13:05:49 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 In-Reply-To: <831uexbrz0.fsf@gnu.org> X-Enigmail-Version: 1.4.6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68292 Archived-At: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig297DACCECA62E4AED09D8CEB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 12/10/2012 11:57 AM, Eli Zaretskii wrote: >> Date: Mon, 10 Dec 2012 08:24:30 -0800 >> From: Daniel Colascione >> CC: 12993@debbugs.gnu.org, angelo.graziosi@alice.it >> >>> SetErrorMode (SEM_FAILCRITICALERRORS); >>> - >>> - /* Invoke the NT CRT startup routine now that our housecleanin= g >>> - is finished. */ >>> -#ifdef HAVE_NTGUI >>> - /* determine WinMain args like crt0.c does */ >>> - hinst =3D GetModuleHandle (NULL); >>> - lpCmdLine =3D GetCommandLine (); >>> - nCmdShow =3D SW_SHOWDEFAULT; >>> -#endif >>> mainCRTStartup (); >>> } >>> >>> What do you know about lpCmdLine and nCmdShow, and "what crt0.c does"= >>> with them, to be sure they can be removed? >> >> I removed dead code. Those variables are never used; the C runtime (to= >> which we dynamically link anyway) handles this initialization >> internally. >=20 > I'm not sure. To me, it looks like we are _replacing_ the _start > function from the C runtime, and therefore whoever wrote this code > wanted to do things like the C runtime does. I see similar code in > crt0.c from the Windows Platform SDK. If you know why this is dead > code, please tell the details. I don't see that code in my copy of VS10's crt0.c. The code is useless because it doesn't affect program execution. The symb= ols lpCmdLine and nCmdShow are defined only because we define them. (If you d= eclare them extern without defining them, compilation fails.) Therefore, Emacs i= s the only user of these variables. The variables aren't used elsewhere in Emac= s code either. --------------enig297DACCECA62E4AED09D8CEB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (Cygwin) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iEYEARECAAYFAlDGTqgACgkQ17c2LVA10VtzvQCgtpfFXpjf9BOj8wJZYwJVJQsN 3IQAn3XEimZjewV38KtbzY0NsVrAWRak =wQaQ -----END PGP SIGNATURE----- --------------enig297DACCECA62E4AED09D8CEB--