From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#12921: 24.2.50; resizing backtrace buffer not persistent (again) Date: Sun, 18 Nov 2012 12:36:52 +0100 Message-ID: <50A8C854.1000302@gmx.at> References: <87r4nr4n6h.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1353238692 5360 80.91.229.3 (18 Nov 2012 11:38:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Nov 2012 11:38:12 +0000 (UTC) Cc: 12921@debbugs.gnu.org To: michael_heerdegen@web.de Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 18 12:38:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ta3Ch-0007eD-8C for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Nov 2012 12:38:23 +0100 Original-Received: from localhost ([::1]:41824 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta3CX-0007j3-5l for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Nov 2012 06:38:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:50218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta3CS-0007if-G0 for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 06:38:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta3CP-0001Yy-DL for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 06:38:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta3CP-0001Yu-9p for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 06:38:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ta3DK-0000S1-GM for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 06:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Nov 2012 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12921-submit@debbugs.gnu.org id=B12921.13532386821611 (code B ref 12921); Sun, 18 Nov 2012 11:39:02 +0000 Original-Received: (at 12921) by debbugs.gnu.org; 18 Nov 2012 11:38:02 +0000 Original-Received: from localhost ([127.0.0.1]:52277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ta3CL-0000Pe-Kh for submit@debbugs.gnu.org; Sun, 18 Nov 2012 06:38:02 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:59472) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1Ta3CJ-0000OP-Ix for 12921@debbugs.gnu.org; Sun, 18 Nov 2012 06:38:00 -0500 Original-Received: (qmail invoked by alias); 18 Nov 2012 11:37:01 -0000 Original-Received: from 62-47-48-54.adsl.highway.telekom.at (EHLO [62.47.48.54]) [62.47.48.54] by mail.gmx.net (mp017) with SMTP; 18 Nov 2012 12:37:01 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/n4nkdoB3n9hxxBjvw6loHS3bwuiic4wKN2Hsaiu z71DvG63kZQR43 In-Reply-To: <87r4nr4n6h.fsf@web.de> X-Y-GMX-Trusted: 0 X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 0.8 (/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67116 Archived-At: > In emacs -Q, type M-x debug. The frame gets split vertically. The > window below displays *Backtrace*. But dragging the mode-line in the > middle doesn't resize the window persistently when you step in the > debugger. > > Resizing is performed here in these lines of `debug': > > (if (eq debugger-previous-window debugger-window) > (when debugger-jumping-flag > ;; Try to restore previous height of debugger > ;; window. > (condition-case nil > (window-resize > debugger-window > (- debugger-previous-window-height > (window-total-size debugger-window))) > (error nil))) > (setq debugger-previous-window debugger-window)) > > However, in the above case, (eq debugger-previous-window > debugger-window) is never true, probably because the vertical splitting > into two windows is performed and undone on each step. > > Would it be harmful to perform resizing unconditionally? This fixes > the problem for me, but I'm not sure if it could be harmful in certain > situations. OTOH, if the window was created newly when the debugger had > been reentered, we already changed the window layout, so forcing a > certain size should not be dangerous, in general. You mean a patch like the below? Note that I have no idea how the debugger should behave when the window layout is changed by the debugged code. martin *** lisp/emacs-lisp/debug.el 2012-11-11 01:16:25 +0000 --- lisp/emacs-lisp/debug.el 2012-11-18 09:55:27 +0000 *************** *** 228,247 **** debugger-buffer `((display-buffer-reuse-window display-buffer-in-previous-window) ! . (,(when debugger-previous-window ! `(previous-window . ,debugger-previous-window))))) (setq debugger-window (selected-window)) ! (if (eq debugger-previous-window debugger-window) ! (when debugger-jumping-flag ! ;; Try to restore previous height of debugger ! ;; window. ! (condition-case nil ! (window-resize ! debugger-window ! (- debugger-previous-window-height ! (window-total-size debugger-window))) ! (error nil))) ! (setq debugger-previous-window debugger-window)) (debugger-mode) (debugger-setup-buffer debugger-args) (when noninteractive --- 228,246 ---- debugger-buffer `((display-buffer-reuse-window display-buffer-in-previous-window) ! . (,(when debugger-previous-window ! `(previous-window . ,debugger-previous-window))))) (setq debugger-window (selected-window)) ! (when debugger-jumping-flag ! ;; Try to restore previous height of debugger ! ;; window. ! (condition-case nil ! (window-resize ! debugger-window ! (- debugger-previous-window-height ! (window-total-size debugger-window))) ! (error nil))) ! (setq debugger-previous-window debugger-window) (debugger-mode) (debugger-setup-buffer debugger-args) (when noninteractive