From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12881: Assume at least POSIX.1-1988 for fcntl.h Date: Sat, 17 Nov 2012 20:41:24 -0800 Organization: UCLA Computer Science Department Message-ID: <50A866F4.3070203@cs.ucla.edu> References: <50A34A56.9080007@cs.ucla.edu> <83y5i4t7gm.fsf@gnu.org> <50A48C67.7020603@cs.ucla.edu> <83ip96u5ic.fsf@gnu.org> <50A54B89.2080505@cs.ucla.edu> <83mwyhswqo.fsf@gnu.org> <50A80CEA.4030207@cs.ucla.edu> <83obiv1slh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1353213734 4478 80.91.229.3 (18 Nov 2012 04:42:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Nov 2012 04:42:14 +0000 (UTC) Cc: 12881@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 18 05:42:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZwi9-0004FE-6W for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Nov 2012 05:42:25 +0100 Original-Received: from localhost ([::1]:55348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZwhz-0004dh-61 for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Nov 2012 23:42:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZwht-0004cl-LF for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 23:42:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZwhq-00022N-IV for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 23:42:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZwhq-00022J-FS for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 23:42:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZwik-0007l9-4F for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 23:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Nov 2012 04:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12881-submit@debbugs.gnu.org id=B12881.135321374029777 (code B ref 12881); Sun, 18 Nov 2012 04:43:02 +0000 Original-Received: (at 12881) by debbugs.gnu.org; 18 Nov 2012 04:42:20 +0000 Original-Received: from localhost ([127.0.0.1]:51861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZwi3-0007kD-R7 for submit@debbugs.gnu.org; Sat, 17 Nov 2012 23:42:20 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:39464) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZwi1-0007k6-V2 for 12881@debbugs.gnu.org; Sat, 17 Nov 2012 23:42:19 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 3BBEFA60017; Sat, 17 Nov 2012 20:41:21 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O83OQ-LxecRN; Sat, 17 Nov 2012 20:41:20 -0800 (PST) Original-Received: from [192.168.1.3] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id D95BCA60001; Sat, 17 Nov 2012 20:41:20 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 In-Reply-To: <83obiv1slh.fsf@gnu.org> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: -1.6 (-) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67108 Archived-At: On 11/17/2012 07:46 PM, Eli Zaretskii wrote: > O_RDWR doesn't need to be defined > (it is already defined by a Windows system header) OK, sorry, I misunderstood your earlier recommendation (to move O_NOCTTY) to also refer to O_RDWR. If you like, I can easily remove the unnecessary definition of O_RDWR in nt/inc/unistd.h. > defining O_NOCTTY in a header included by many sources is wrong, because it > triggers compilation of other non-Windows friendly code elsewhere. No, there's no "#ifdef O_NOCTTY" or "#if ... defined O_NOCTTY ..." anywhere in Emacs that would be affected by this definition. The non-Microsoft code already falls back on "#define O_NOCTTY 0" for platforms that lack O_NOCTTY, and the Microsoft code can safely do the same. > Looks like I invested all that effort in vain I don't see why here, either. Neither of these appear to be problems that would break a build or cause Emacs to misbehave. And even if they were, any fixes would be trivial.