From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12881: Assume at least POSIX.1-1988 for fcntl.h Date: Sat, 17 Nov 2012 14:17:14 -0800 Organization: UCLA Computer Science Department Message-ID: <50A80CEA.4030207@cs.ucla.edu> References: <50A34A56.9080007@cs.ucla.edu> <83y5i4t7gm.fsf@gnu.org> <50A48C67.7020603@cs.ucla.edu> <83ip96u5ic.fsf@gnu.org> <50A54B89.2080505@cs.ucla.edu> <83mwyhswqo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1353190698 16224 80.91.229.3 (17 Nov 2012 22:18:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Nov 2012 22:18:18 +0000 (UTC) Cc: 12881-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 17 23:18:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZqiY-0002Tt-7b for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Nov 2012 23:18:26 +0100 Original-Received: from localhost ([::1]:38015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZqiO-00037o-4o for geb-bug-gnu-emacs@m.gmane.org; Sat, 17 Nov 2012 17:18:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZqiJ-00036a-Lh for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 17:18:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZqiG-0003Fv-Jc for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 17:18:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZqiG-0003Fp-G4 for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 17:18:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TZqj8-0005l2-Jq for bug-gnu-emacs@gnu.org; Sat, 17 Nov 2012 17:19:02 -0500 Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Nov 2012 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 12881@debbugs.gnu.org, eggert@cs.ucla.edu, eggert@cs.ucla.edu Original-Received: via spool by 12881-done@debbugs.gnu.org id=D12881.135319069022069 (code D ref 12881); Sat, 17 Nov 2012 22:19:02 +0000 Original-Received: (at 12881-done) by debbugs.gnu.org; 17 Nov 2012 22:18:10 +0000 Original-Received: from localhost ([127.0.0.1]:51462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZqiH-0005jt-Nm for submit@debbugs.gnu.org; Sat, 17 Nov 2012 17:18:10 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:58143) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TZqiF-0005jm-Lf for 12881-done@debbugs.gnu.org; Sat, 17 Nov 2012 17:18:08 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id EEF9FA60001; Sat, 17 Nov 2012 14:17:12 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uST2d4okMYUe; Sat, 17 Nov 2012 14:17:12 -0800 (PST) Original-Received: from [192.168.1.3] (pool-71-189-154-249.lsanca.fios.verizon.net [71.189.154.249]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 999D739E8008; Sat, 17 Nov 2012 14:17:12 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 In-Reply-To: <83mwyhswqo.fsf@gnu.org> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: -1.6 (-) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67086 Archived-At: On 11/16/2012 01:49 AM, Eli Zaretskii wrote: > I wonder how it compiled for you; > presumably some other header on your platform includes fcntl.h > internally It's systty.h, which includes fcntl.h everywhere. But it doesn't hurt to include it again, so I did that. I took the other suggestions you made as well, except that I moved the replacement definitions of O_RDWR and O_NOCTTY into nt/inc/unistd.h rather than to some other spot in term.c. It's cleaner to define system macros in our implementation of the system rather than in the application. In the longer run we may want to move those macros to a new file that replaces fcntl.h, but that's for another day. I installed this as trunk bzr 110931 and am marking it as done.