From: martin rudalics <rudalics@gmx.at>
To: michael_heerdegen@web.de
Cc: 12854@debbugs.gnu.org
Subject: bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented
Date: Tue, 13 Nov 2012 14:50:46 +0100 [thread overview]
Message-ID: <50A25036.8070008@gmx.at> (raw)
In-Reply-To: <87a9upp8qb.fsf@web.de>
> (defun display-buffer-assq-regexp (buffer-name alist)
> "Retrieve ALIST entry corresponding to BUFFER-NAME."
> (catch 'match
> (dolist (entry alist)
> (let ((key (car entry)))
> (when (or (and (stringp key)
> (string-match-p key buffer-name))
> (and (symbolp key) (functionp key)
> (funcall key buffer-name alist)))
> (throw 'match (cdr entry)))))))
>
>
> Obviously, two things are wrong here:
>
> (1) If CONDITION is a function, it currently must be a symbol. I don't
> see why lambda expressions should be forbidden. The user should not
> need to use defun only to be able specify an argument.
I see no problems with removing the (symbolp key) check.
> (2) If CONDITION is a function, it takes _two_ arguments: a buffer
> _name_ (not a buffer) _and_ an alist. That should be clarified in the
> docstring.
IIUC the correct solution is to not pass ALIST to the function specified
by `key'.
martin
next prev parent reply other threads:[~2012-11-13 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-10 19:18 bug#12854: 24.2.50; `display-buffer-alist': conditions are not handled as documented Michael Heerdegen
2012-11-10 19:42 ` Michael Heerdegen
2012-11-16 15:33 ` martin rudalics
2012-11-18 1:02 ` Michael Heerdegen
2012-11-13 13:50 ` martin rudalics [this message]
2012-11-16 15:32 ` martin rudalics
2012-11-18 1:00 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A25036.8070008@gmx.at \
--to=rudalics@gmx.at \
--cc=12854@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.