From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 12766@debbugs.gnu.org
Subject: bug#12766: read-from-minibuffer does not preserve current-buffer
Date: Wed, 31 Oct 2012 11:27:15 +0100 [thread overview]
Message-ID: <5090FD03.9080405@gmx.at> (raw)
In-Reply-To: <jwv390vlqbp.fsf-monnier+emacs@gnu.org>
> Right, I would expect it to fix the problem, indeed. IOW, please
> install.
Installed in revision 110748 on trunk.
> But I still wonder, how come this was not needed earlier.
I didn't go through it but IIUC read_minibuf calls choose_minibuf_frame
which calls Fset_frame_selected_window for each frame which now, for the
selected window, unconditionally makes its buffer current.
For me the fact that unwinding a sequence of operations as
choose_minibuf_frame ();
record_unwind_protect (choose_minibuf_frame_1, Qnil);
record_unwind_protect (Fset_window_configuration,
Fcurrent_window_configuration (Qnil));
record_unwind_protect (Fset_window_configuration,
Fcurrent_window_configuration (mini_frame));
would work in practice constitutes a miracle already.
martin
next prev parent reply other threads:[~2012-10-31 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 20:29 bug#12766: read-from-minibuffer does not preserve current-buffer Stefan Monnier
2012-10-30 10:27 ` martin rudalics
2012-10-30 13:51 ` Stefan Monnier
2012-10-30 18:49 ` martin rudalics
2012-10-30 19:21 ` Stefan Monnier
2012-10-31 10:27 ` martin rudalics [this message]
2012-10-31 14:07 ` Stefan Monnier
2012-11-09 9:50 ` martin rudalics
2012-11-09 14:20 ` Stefan Monnier
2012-11-10 11:07 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090FD03.9080405@gmx.at \
--to=rudalics@gmx.at \
--cc=12766@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.