From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
50777@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#50777: Dropping EIEIO from xref (for performance)
Date: Sun, 26 Sep 2021 04:15:27 +0300 [thread overview]
Message-ID: <508ef22b-02e2-c67b-3e34-be47d22f3328@yandex.ru> (raw)
In-Reply-To: <c0af84cd-ca85-6a9c-5c82-7d6409e241f1@yandex.ru>
On 24.09.2021 18:32, Dmitry Gutov wrote:
> One area of bigger concern is whether code compiled against the new
> version of Xref would work with the old one without recompiling (and
> vice versa). I guess for that to work we need to disable inlining on
> xref-item's accessors, at least. Maybe there's something else I'm missing.
OK, so I've done some testing with ivy-xref (fixing it to stop using
with-slots), and (:noinline t) indeed seems necessary for Emacs using
previous version of xref to run code from ivy-xref.elc compiled with the
newer version without errors.
But since I tested this in Emacs 27,
(void-function make-closure)
was a much bigger problem. This is apparently how lambdas are compiled now.
So this is a +1 minor reason to release the new version together with
Emacs 28: less need to worry about :noinline. Though we could use it
anyway, to avoid tying byte code to a particular implementation: the
performance seems unchanged.
next prev parent reply other threads:[~2021-09-26 1:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 13:28 bug#50777: Dropping EIEIO from xref (for performance) Dmitry Gutov
2021-09-24 13:35 ` Dmitry Gutov
2021-09-24 13:37 ` Dmitry Gutov
2021-09-24 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 15:32 ` Dmitry Gutov
2021-09-26 1:15 ` Dmitry Gutov [this message]
2021-09-26 8:51 ` Mattias Engdegård
2021-09-26 18:34 ` Dmitry Gutov
2021-09-24 15:12 ` Arthur Miller
2021-09-25 1:42 ` Lars Ingebrigtsen
2021-09-25 1:52 ` Dmitry Gutov
2021-09-25 14:07 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-26 2:16 ` Dmitry Gutov
2021-09-30 21:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508ef22b-02e2-c67b-3e34-be47d22f3328@yandex.ru \
--to=dgutov@yandex.ru \
--cc=50777@debbugs.gnu.org \
--cc=mardani29@yahoo.es \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.