From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: shrink-window-if-larger-than-buffer in VC-diff Date: Sat, 27 Oct 2012 15:45:41 +0200 Message-ID: <508BE585.4000309@gmx.at> References: <87aaoo7pmj.fsf@stupidchicken.com> <87iq3bs168.fsf@stupidchicken.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1351345557 20177 80.91.229.3 (27 Oct 2012 13:45:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Oct 2012 13:45:57 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 27 15:46:05 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TS6iD-0002i9-9M for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2012 15:46:05 +0200 Original-Received: from localhost ([::1]:39248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TS6i5-0002wj-E8 for ged-emacs-devel@m.gmane.org; Sat, 27 Oct 2012 09:45:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TS6i2-0002u1-VT for emacs-devel@gnu.org; Sat, 27 Oct 2012 09:45:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TS6i0-0005wp-VF for emacs-devel@gnu.org; Sat, 27 Oct 2012 09:45:54 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:41075) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1TS6i0-0005vU-Lw for emacs-devel@gnu.org; Sat, 27 Oct 2012 09:45:52 -0400 Original-Received: (qmail invoked by alias); 27 Oct 2012 13:45:50 -0000 Original-Received: from 62-47-63-98.adsl.highway.telekom.at (EHLO [62.47.63.98]) [62.47.63.98] by mail.gmx.net (mp004) with SMTP; 27 Oct 2012 15:45:50 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/XwGRVRb3XbK9ak0+rBVyi9z2M8hQvIL9RbjtyER LUovnLu7z4PanA In-Reply-To: <87iq3bs168.fsf@stupidchicken.com> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154537 Archived-At: > Maybe we should change `pop-to-buffer' so that it accepts > an option to both shrink *and* grow windows. Then people who want their > windows to resize automagically can use this option, and have it work > more reliably than it does now. This is now possible using the `window-height' and `window-width' alist entries. There are currently two major problems with this: (1) `temp-buffer-resize-mode' overrides it. This is no problem for `with-output-to-temp-buffer' since that macro encapsulates the `display-buffer' call. But `with-temp-buffer-window' has an ACTION argument which can be now overridden and manually activating `temp-buffer-resize-mode' in a buffer will accomplish the same. (2) I'm not sure what to do with `fit-window-to-buffer' and `shrink-window-if-larger-than-buffer' calls that happen after `display-buffer' like in `vc-root-diff'. In principle, I could have `display-buffer' add a window parameter or a buffer-local variable to handle such cases. But neither of them look very attractive to me. Any suggestions? > (The default should be to avoid > resizing at all.) I disagree here. We should try to preserve the previous behavior. martin