all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel@gnu.org
Subject: Re: shrink-window-if-larger-than-buffer in VC-diff
Date: Sat, 27 Oct 2012 15:45:41 +0200	[thread overview]
Message-ID: <508BE585.4000309@gmx.at> (raw)
In-Reply-To: <87iq3bs168.fsf@stupidchicken.com>

 > Maybe we should change `pop-to-buffer' so that it accepts
 > an option to both shrink *and* grow windows.  Then people who want their
 > windows to resize automagically can use this option, and have it work
 > more reliably than it does now.

This is now possible using the `window-height' and `window-width' alist
entries.  There are currently two major problems with this:

(1) `temp-buffer-resize-mode' overrides it.  This is no problem for
`with-output-to-temp-buffer' since that macro encapsulates the
`display-buffer' call.  But `with-temp-buffer-window' has an ACTION
argument which can be now overridden and manually activating
`temp-buffer-resize-mode' in a buffer will accomplish the same.

(2) I'm not sure what to do with `fit-window-to-buffer' and
`shrink-window-if-larger-than-buffer' calls that happen after
`display-buffer' like in `vc-root-diff'.  In principle, I could have
`display-buffer' add a window parameter or a buffer-local variable to
handle such cases.  But neither of them look very attractive to me.

Any suggestions?

 > (The default should be to avoid
 > resizing at all.)

I disagree here.  We should try to preserve the previous behavior.

martin



      parent reply	other threads:[~2012-10-27 13:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 23:15 shrink-window-if-larger-than-buffer in VC-diff Chong Yidong
2010-08-15  1:14 ` Miles Bader
2010-08-15  7:07 ` Andreas Schwab
2010-08-15  9:38 ` annoyances [Was: shrink-window-if-larger-than-buffer in VC-diff] Uday S Reddy
2010-08-15 10:06   ` annoyances David Kastrup
2010-08-15 10:33     ` annoyances Uday S Reddy
2010-08-15 14:12   ` annoyances [Was: shrink-window-if-larger-than-buffer in VC-diff] Stephen J. Turnbull
2010-08-15 18:35     ` Uday S Reddy
2010-08-16  1:45       ` Stephen J. Turnbull
2010-08-16  8:54         ` Uday S Reddy
2010-08-15 22:44 ` shrink-window-if-larger-than-buffer in VC-diff Juanma Barranquero
2010-08-16  3:10   ` Chong Yidong
2010-08-16 23:06     ` Juanma Barranquero
2010-08-18 21:53       ` Chong Yidong
2010-08-20  9:06         ` martin rudalics
2012-10-27 13:45     ` martin rudalics [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508BE585.4000309@gmx.at \
    --to=rudalics@gmx.at \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.