From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Tue, 23 Oct 2012 13:01:39 -0700 Message-ID: <5086F7A3.3040401@cs.ucla.edu> References: <5078CAB6.7020509@cs.ucla.edu> <83fw5h5yo6.fsf@gnu.org> <507B010F.20105@cs.ucla.edu> <831uh06gqd.fsf@gnu.org> <507B15B0.2040802@cs.ucla.edu> <83txtw4xmk.fsf@gnu.org> <507B2354.3030408@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> <507CF802.6000305@cs.ucla.edu> <83a9vm4bmv.fsf@gnu.org> <50818763.80501@cs.ucla.edu> <83wqymz4me.fsf@gnu.org> <5081A1DF.9000009@cs.ucla.edu> <5081ABD6.9060002@cs.ucla.edu> <23r4osd2f9.fsf@fencepost.gnu.org> <50836366.6080600@cs.ucla.edu> <5084E1B2.2020105@cs.ucla.edu> <83ipa2ctl2.fsf@gnu.org> <5085AD9E.7040701@cs.ucla.edu> <838vaycj65.fsf@gnu.org> <5085BB01.2030402@cs.ucla.edu> <836261df2p.fsf@gnu.org> <50862604.30208@cs.ucla.edu> <83vce1b0ja.fsf@gnu.org> <5086EF99.6060008@cs.ucla.edu> <83sj95ary0.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1351022539 17397 80.91.229.3 (23 Oct 2012 20:02:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 20:02:19 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 23 22:02:27 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQkgC-0002he-8I for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 22:02:24 +0200 Original-Received: from localhost ([::1]:37764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkg4-0001OV-ET for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 16:02:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkfy-0001OK-1q for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 16:02:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQkfw-0005qf-V9 for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 16:02:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQkfw-0005qZ-Sh for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 16:02:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQkhm-0000xu-9V for bug-gnu-emacs@gnu.org; Tue, 23 Oct 2012 16:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2012 20:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.13510226243687 (code B ref 12632); Tue, 23 Oct 2012 20:04:02 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 23 Oct 2012 20:03:44 +0000 Original-Received: from localhost ([127.0.0.1]:58219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkhT-0000xO-4K for submit@debbugs.gnu.org; Tue, 23 Oct 2012 16:03:43 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:48048) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQkhQ-0000wt-1m for 12632@debbugs.gnu.org; Tue, 23 Oct 2012 16:03:41 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 98C8BA60007; Tue, 23 Oct 2012 13:01:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id grrACrZSfPuk; Tue, 23 Oct 2012 13:01:40 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 19640A60003; Tue, 23 Oct 2012 13:01:40 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 In-Reply-To: <83sj95ary0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65947 Archived-At: On 10/23/2012 12:50 PM, Eli Zaretskii wrote: > Just file_directory_p is enough Thanks, I'll simplify that part to: bool file_accessible_directory_p (char const *file) { #ifdef DOS_NT /* There's no need to test whether FILE is searchable, as the searchable/executable bit is invented on DOS_NT platforms. */ return file_directory_p (file); #else ... same as before ... #endif }