From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Mon, 15 Oct 2012 23:00:34 -0700 Organization: UCLA Computer Science Department Message-ID: <507CF802.6000305@cs.ucla.edu> References: <5078CAB6.7020509@cs.ucla.edu> <83fw5i7s4p.fsf@gnu.org> <83a9vq7oqh.fsf@gnu.org> <507A58CC.10209@cs.ucla.edu> <83fw5h5yo6.fsf@gnu.org> <507B010F.20105@cs.ucla.edu> <831uh06gqd.fsf@gnu.org> <507B15B0.2040802@cs.ucla.edu> <83txtw4xmk.fsf@gnu.org> <507B2354.3030408@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1350367324 16824 80.91.229.3 (16 Oct 2012 06:02:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2012 06:02:04 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 16 08:02:11 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TO0EC-0005m6-Sb for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2012 08:02:09 +0200 Original-Received: from localhost ([::1]:50484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO0E5-00087x-LV for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Oct 2012 02:02:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO0E3-00087r-0L for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 02:02:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TO0Dw-0006OK-9x for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 02:01:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TO0Dw-0006OE-6Y for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 02:01:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TO0F3-0006iW-SX for bug-gnu-emacs@gnu.org; Tue, 16 Oct 2012 02:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Oct 2012 06:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.135036733225763 (code B ref 12632); Tue, 16 Oct 2012 06:03:01 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 16 Oct 2012 06:02:12 +0000 Original-Received: from localhost ([127.0.0.1]:46025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TO0EF-0006hS-9n for submit@debbugs.gnu.org; Tue, 16 Oct 2012 02:02:11 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:59807) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TO0EC-0006hE-5b for 12632@debbugs.gnu.org; Tue, 16 Oct 2012 02:02:09 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 31A7639E8108; Mon, 15 Oct 2012 23:00:51 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OiZecBSkwWKI; Mon, 15 Oct 2012 23:00:44 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E8FE7A60003; Mon, 15 Oct 2012 23:00:38 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 In-Reply-To: <83d30j3wqg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65654 Archived-At: On 10/15/2012 08:46 PM, Eli Zaretskii wrote: >> why bother to make a special case for F_OK? > Because it's more universally available faccessat is just as available, on the platforms that the (patched) Emacs will run on: it's available either natively or via supplied emulation. > I believe also more efficient. I thought the point of Bug#12587 was that on Windows, 'stat' can be way slower than faccessat, so much so that Emacs appears unresponsive. 'stat' is also slower than faccessat on Solaris, though the performance difference is not as great as it appears to be on Windows. 'stat' is faster than faccessat on GNU/Linux, true, but the performance difference isn't great enough to make a special case just for that platform.