From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12600@debbugs.gnu.org
Subject: bug#12600: 24.2.50; linum-mode: line numbers in fringe do not refresh when resizing frame
Date: Thu, 11 Oct 2012 09:12:50 +0200 [thread overview]
Message-ID: <50767172.4060807@gmx.at> (raw)
In-Reply-To: <83ehl6z5y0.fsf@gnu.org>
> It was disabled with a comment saying
>
> #if 0 /* This change broke some things. We should make it later. */
> ^^^^^^^^^^^^^^^^^^^^^^^
> If everybody agrees that the doc string is wrong, then we should
> permanently delete this code when we update the doc. Otherwise, some
> day the function will begin returning nil, and applications should be
> prepared for that.
Looking at the ChangeLogs this apparently changed back and forth two
times with limited success.
>> > if (! NILP (update)
>> > && ! (! NILP (w->window_end_valid)
>> > && w->last_modified >= BUF_MODIFF (b)
>> > && w->last_overlay_modified >= BUF_OVERLAY_MODIFF (b))
>> > && !noninteractive)
>>
>> Is there anything that has not been set when the frame got resized?
>
> I'm guessing it's the window_end_valid flag, since no buffer changes
> are involved in the recipe. Which probably means that the resize did
> not yet become known to the display engine by the time this function
> is called.
>
> Of course, this is all theory, and I was wrong before. It would be
> best to trace this with a debugger and see what's going on.
I have no idea what these window structure members (window_end_valid,
last_modified and last_overlay_modified) stand for in practice, who's
supposed to set them, why and when. At least setting window_end_valid
to Qnil in window_resize_apply did not help. But writing
if (! NILP (update)
/** && ! (! NILP (w->window_end_valid) **/
/** && w->last_modified >= BUF_MODIFF (b) **/
/** && w->last_overlay_modified >= BUF_OVERLAY_MODIFF (b)) **/
&& !noninteractive)
makes the problem disappear.
So apparently this can be fixed easily but as long as I don't understand
that cryptic conjunct I won't do it.
martin
next prev parent reply other threads:[~2012-10-11 7:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 23:03 bug#12600: 24.2.50; linum-mode: line numbers in fringe do not refresh when resizing frame Christoph Scholtes
2012-10-08 7:31 ` Eli Zaretskii
2012-10-08 9:17 ` martin rudalics
2012-10-08 13:59 ` Stefan Monnier
2012-10-08 15:48 ` Eli Zaretskii
2012-10-09 9:36 ` martin rudalics
2012-10-09 17:04 ` Eli Zaretskii
2012-10-10 10:22 ` martin rudalics
2012-10-10 15:45 ` Eli Zaretskii
2012-10-11 7:12 ` martin rudalics [this message]
2012-10-11 16:56 ` Eli Zaretskii
2012-10-12 7:32 ` martin rudalics
2012-10-12 8:52 ` Eli Zaretskii
2012-10-12 9:35 ` martin rudalics
2012-10-12 13:51 ` Eli Zaretskii
2012-10-12 15:42 ` martin rudalics
2012-10-12 14:55 ` Stefan Monnier
2012-10-12 15:36 ` Eli Zaretskii
2012-10-12 15:43 ` martin rudalics
2012-10-13 8:56 ` Eli Zaretskii
2012-10-13 9:51 ` martin rudalics
2012-10-13 12:45 ` Eli Zaretskii
2012-10-13 17:45 ` martin rudalics
2012-10-13 18:08 ` Eli Zaretskii
2012-10-14 10:21 ` martin rudalics
2012-10-14 12:06 ` Eli Zaretskii
2012-10-14 18:33 ` martin rudalics
2012-10-14 20:01 ` Eli Zaretskii
2012-10-15 9:41 ` martin rudalics
2012-10-15 19:39 ` Eli Zaretskii
2012-10-16 9:39 ` martin rudalics
2012-10-16 17:35 ` Eli Zaretskii
2012-10-15 9:40 ` martin rudalics
2012-11-09 9:49 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50767172.4060807@gmx.at \
--to=rudalics@gmx.at \
--cc=12600@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.