From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files Date: Fri, 05 Oct 2012 09:05:10 +0200 Message-ID: <506E86A6.5020008@gmx.at> References: <87r4t1sk9o.fsf@web.de> <87sjdhily5@ch.ristopher.com> <06AF8E7E174A4F768ADB2B901755EA3C@us.oracle.com> <871ul0bymm@ch.ristopher.com> <87zk7ozman.fsf@web.de> <87d34kfxa3@ch.ristopher.com> <87d34kzcr8.fsf@web.de> <873958b2cm.fsf@web.de> <4FF40A79.5000707@gmx.at> <87ipcbmt6d.fsf@web.de> <50348571.1070605@gmx.at> <87bohtlo9d@ch.ristopher.com> <87a9xdoet6.fsf@web.de> <506C01ED.9000906@gmx.at> <87626phk2m.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349420761 24190 80.91.229.3 (5 Oct 2012 07:06:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2012 07:06:01 +0000 (UTC) Cc: 11795@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 05 09:06:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TK1z4-0005VI-A4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Oct 2012 09:06:06 +0200 Original-Received: from localhost ([::1]:51297 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK1yy-0004ou-HQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Oct 2012 03:06:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK1ys-0004od-MG for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK1yr-0007At-Du for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:54 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK1yr-0007Af-Aa for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TK1z0-0000pE-DI for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Oct 2012 07:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11795 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13494207383142 (code B ref -1); Fri, 05 Oct 2012 07:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Oct 2012 07:05:38 +0000 Original-Received: from localhost ([127.0.0.1]:54997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TK1ya-0000oc-Ne for submit@debbugs.gnu.org; Fri, 05 Oct 2012 03:05:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38045) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TK1yY-0000oQ-HX for submit@debbugs.gnu.org; Fri, 05 Oct 2012 03:05:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK1yE-0006fk-Fh for submit@debbugs.gnu.org; Fri, 05 Oct 2012 03:05:20 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:60871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK1yE-0006fW-DC for submit@debbugs.gnu.org; Fri, 05 Oct 2012 03:05:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK1yD-0004cQ-BY for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK1yC-0006dE-9n for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:13 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:60719) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1TK1yC-0006bl-0c for bug-gnu-emacs@gnu.org; Fri, 05 Oct 2012 03:05:12 -0400 Original-Received: (qmail invoked by alias); 05 Oct 2012 07:05:09 -0000 Original-Received: from 62-47-57-32.adsl.highway.telekom.at (EHLO [62.47.57.32]) [62.47.57.32] by mail.gmx.net (mp069) with SMTP; 05 Oct 2012 09:05:09 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+bajJLiIab7jK4uQyV79Q+4YXotQIsPiGtTAQshn ovQ7mSy6Sdpz9+ In-Reply-To: <87626phk2m.fsf@web.de> X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65221 Archived-At: > Martin, I would rather like to discuss first what we do with bug#12394. > Can you please have a look? It would be good to know what we want to > change for that bug before applying a patch for this. IIRC `wdired' is full of such niceties. Here the problem is that `dired-move-to-filename' moves to the start of the old filename, skipping the prepended string. Maybe it's sufficient to remove that call as in the patch below since the subsequent (search-forward (wdired-get-filename t) nil t) should move to the right position anyway. If not, we'll have to rewrite this function from scratch. martin *** lisp/wdired.el 2012-08-05 04:19:21 +0000 --- lisp/wdired.el 2012-10-05 06:36:43 +0000 *************** *** 506,512 **** (progn (setq done t) (let ((inhibit-read-only t)) ! (dired-move-to-filename) (search-forward (wdired-get-filename t) nil t) (replace-match (file-name-nondirectory filename-ori) t t)) (dired-do-create-files-regexp --- 506,512 ---- (progn (setq done t) (let ((inhibit-read-only t)) ! ;; (dired-move-to-filename) (search-forward (wdired-get-filename t) nil t) (replace-match (file-name-nondirectory filename-ori) t t)) (dired-do-create-files-regexp