* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race
[not found] <E1TJ8u5-0005Oq-4a@vcs.savannah.gnu.org>
@ 2012-10-03 1:52 ` Stefan Monnier
2012-10-04 5:53 ` Paul Eggert
2012-10-03 1:56 ` Stefan Monnier
1 sibling, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2012-10-03 1:52 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-devel
> + /* record_backtrace uses hash functions that call Fequal, which
> + uses QUIT, which can call malloc, which can cause disaster in
> + a signal handler. So inhibit QUIT. */
Oh, yuck! Good point!
Then we probably also want to hide pending_signals.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race
[not found] <E1TJ8u5-0005Oq-4a@vcs.savannah.gnu.org>
2012-10-03 1:52 ` [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race Stefan Monnier
@ 2012-10-03 1:56 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2012-10-03 1:56 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-diffs
> + /* record_backtrace uses hash functions that call Fequal, which
> + uses QUIT, which can call malloc, which can cause disaster in
> + a signal handler. So inhibit QUIT. */
Actually, we'd probably be better off using a different hash-function
(and equality test) so as to make sure we don't run QUIT at all.
We could use it to improve the equality function such that different
closures coming from the same source code (IOW different instances of
the same source function) are considered equal.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race
2012-10-03 1:52 ` [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race Stefan Monnier
@ 2012-10-04 5:53 ` Paul Eggert
0 siblings, 0 replies; 3+ messages in thread
From: Paul Eggert @ 2012-10-04 5:53 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 10/02/2012 06:52 PM, Stefan Monnier wrote:
> Then we probably also want to hide pending_signals.
I did that in trunk bzr 110355.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-04 5:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1TJ8u5-0005Oq-4a@vcs.savannah.gnu.org>
2012-10-03 1:52 ` [Emacs-diffs] /srv/bzr/emacs/trunk r110349: * profiler.c (handle_profiler_signal): Fix a malloc race Stefan Monnier
2012-10-04 5:53 ` Paul Eggert
2012-10-03 1:56 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.