From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12541: Prefer plain 'static' to 'static inline'. Date: Tue, 02 Oct 2012 00:00:54 -0700 Organization: UCLA Computer Science Department Message-ID: <506A9126.1040406@cs.ucla.edu> References: <5067FC19.3000704@cs.ucla.edu> <83d313et6t.fsf@gnu.org> <50688861.2090306@cs.ucla.edu> <83y5jrcqe7.fsf@gnu.org> <506893EF.8080604@cs.ucla.edu> <83fw5yazdz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1349161324 26010 80.91.229.3 (2 Oct 2012 07:02:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2012 07:02:04 +0000 (UTC) Cc: 12541-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 02 09:02:08 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIwUM-00088B-W5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2012 09:01:55 +0200 Original-Received: from localhost ([::1]:46140 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIwUH-0006uy-40 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Oct 2012 03:01:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIwUB-0006uq-SS for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 03:01:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIwU0-00060h-4u for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 03:01:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIwU0-00060d-1P for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 03:01:32 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIwUU-00025x-FC for bug-gnu-emacs@gnu.org; Tue, 02 Oct 2012 03:02:02 -0400 Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Oct 2012 07:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 12541@debbugs.gnu.org, eggert@cs.ucla.edu Original-Received: via spool by 12541-done@debbugs.gnu.org id=D12541.13491612908011 (code D ref 12541); Tue, 02 Oct 2012 07:02:01 +0000 Original-Received: (at 12541-done) by debbugs.gnu.org; 2 Oct 2012 07:01:30 +0000 Original-Received: from localhost ([127.0.0.1]:37083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIwTw-000258-M7 for submit@debbugs.gnu.org; Tue, 02 Oct 2012 03:01:30 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:57915) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIwTt-000251-Ol for 12541-done@debbugs.gnu.org; Tue, 02 Oct 2012 03:01:26 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A823D39E8014; Tue, 2 Oct 2012 00:00:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zb2idpSp1O2r; Tue, 2 Oct 2012 00:00:54 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4C88139E8016; Tue, 2 Oct 2012 00:00:54 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 In-Reply-To: <83fw5yazdz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65109 Archived-At: On 10/01/2012 10:14 AM, Eli Zaretskii wrote: > Perhaps that's because STRING_CHAR could call a function? Yes, I suspect that's it. When there's enough register pressure it can sometimes make sense to put a call inside a function rather than inline it. > Nevertheless, I'm okay with removing the 'inline' qualifier from > bidi.c. If the performance hit is significant, I'm sure we will hear > from users shortly. Otherwise, I'll try to measure the performance > with and without 'inline' when I have time, and we can take it from > there. Thanks, I did that as trunk bzr 110345 and am marking this as done. For what it's worth, the amount of inlining often depends greatly on exactly which compiler flags are used -- with GCC, for example, it can matter quite a bit whether one uses -O1, -O2, or -O3.