question about pop-to-buffer

question about pop-to-buffer

[Thierry Volpiatto]

Hi,
how can I set pop-to-buffer action arg to create the new window on top
and not on bottom of current window and split the windows equally.

I tried with this:

#+BEGIN_SRC lisp
(pop-to-buffer (get-buffer-create "*toto*") 
               '(display-buffer-in-side-window . ((side . top) (slot . 0))))

#+END_SRC

I tried several values for slot but it seem to have no effect.

Also if I have two windows the second one is not reused, a new one is
created instead. (but maybe is what `display-buffer-in-side-window' for
?)

Thanks.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: question about pop-to-buffer

[martin rudalics]

 > how can I set pop-to-buffer action arg to create the new window on top
 > and not on bottom of current window and split the windows equally.

Side windows serve a different purpose and don't care about the selected
window.  Moreover you can't set their heights and widths individually:
All side windows on the left or right get the same width once set, all
side windows on the top or bottom have the same height.  And you
currently can't set the size of the first window at some side because
there's a bug in `display-buffer-in-major-side-window' :-(

So in `display-buffer-in-major-side-window' you have to replace

	 (size (or (assq 'size alist)

by

	 (size (or (cdr (assq 'size alist))

and then use for example

(pop-to-buffer
  (get-buffer-create "*toto*")
  `(display-buffer-in-side-window . ((side . top) (size . ,(/ (window-total-size (selected-window)) 2)) (slot . 0))))

which is clumsy and won't work if a window of that size exists already.

Interpreting your request literally with "selected" substituting
"current", I suppose the following should do what you want:

(let ((split-window-preferred-function
        #'(lambda (window) (split-window (selected-window)  nil 'above))))
   (pop-to-buffer (get-buffer-create "*toto*")))

 > Also if I have two windows the second one is not reused, a new one is
 > created instead. (but maybe is what `display-buffer-in-side-window' for
 > ?)

I suppose you have to customize `window-sides-slots' appropriately.

martin

Re: question about pop-to-buffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

>> how can I set pop-to-buffer action arg to create the new window on top
>> and not on bottom of current window and split the windows equally.
>
> Side windows serve a different purpose and don't care about the selected
> window.  Moreover you can't set their heights and widths individually:
> All side windows on the left or right get the same width once set, all
> side windows on the top or bottom have the same height.  And you
> currently can't set the size of the first window at some side because
> there's a bug in `display-buffer-in-major-side-window' :-(
>
> So in `display-buffer-in-major-side-window' you have to replace
>
> 	 (size (or (assq 'size alist)
>
> by
>
> 	 (size (or (cdr (assq 'size alist))
>
> and then use for example
>
> (pop-to-buffer
>  (get-buffer-create "*toto*")
>  `(display-buffer-in-side-window . ((side . top) (size . ,(/ (window-total-size (selected-window)) 2)) (slot . 0))))
>
> which is clumsy and won't work if a window of that size exists already.
>
> Interpreting your request literally with "selected" substituting
> "current", I suppose the following should do what you want:
>
> (let ((split-window-preferred-function
>        #'(lambda (window) (split-window (selected-window)  nil 'above))))
>   (pop-to-buffer (get-buffer-create "*toto*")))
>
>> Also if I have two windows the second one is not reused, a new one is
>> created instead. (but maybe is what `display-buffer-in-side-window' for
>> ?)
>
> I suppose you have to customize `window-sides-slots' appropriately.

Many thanks to take the time to clarify all this.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: question about pop-to-buffer

[martin rudalics]

 > And you
 > currently can't set the size of the first window at some side because
 > there's a bug in `display-buffer-in-major-side-window' :-(

This has been fixed now, hopefully.

 > (pop-to-buffer
 >  (get-buffer-create "*toto*")
 >  `(display-buffer-in-side-window . ((side . top) (size . ,(/
 > (window-total-size (selected-window)) 2)) (slot . 0))))

You now have to use something like

(pop-to-buffer
  (get-buffer-create "*toto*")
  `(display-buffer-in-side-window . ((side . top) (window-height . ,(/ (window-total-size (selected-window)) 2)) (slot . 0))))

martin

Re: question about pop-to-buffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

>> And you
>> currently can't set the size of the first window at some side because
>> there's a bug in `display-buffer-in-major-side-window' :-(
>
> This has been fixed now, hopefully.

Cool.

>> (pop-to-buffer
>>  (get-buffer-create "*toto*")
>>  `(display-buffer-in-side-window . ((side . top) (size . ,(/
>> (window-total-size (selected-window)) 2)) (slot . 0))))
>
> You now have to use something like
>
> (pop-to-buffer
>  (get-buffer-create "*toto*")
>  `(display-buffer-in-side-window . ((side . top) (window-height . ,(/ (window-total-size (selected-window)) 2)) (slot . 0))))
Ok good to know, thanks, however I have removed the variable that was
handling that, and I can manage splitting the windows in helm only using
`split-window-preferred-function' following your advice (I use a
specialized function for this).

Also, I have noticed that window-right/left can also handle vertical
splitting (I.e I was looking for something like window-above/bottom and
I discover that window-right/left do this).
Maybe that can be documented somewhere?

Thanks for your help.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: question about pop-to-buffer

[martin rudalics]

 > Also, I have noticed that window-right/left can also handle vertical
 > splitting (I.e I was looking for something like window-above/bottom and
 > I discover that window-right/left do this).
 > Maybe that can be documented somewhere?

No, and I probably should have called them window--right and
window--left, but I faintly recall having called them from somewhere
outside window.el.  These functions are only useful to avoid writing

   (and window (window-parent window) (window-next-sibling window)))

which is needed for technical reasons because usually the minibuffer
window is the "sibling" of the frame's root window and the window tree
functions should not work on the minibuffer window.  Anyone interested
finds the rationale in the comment preceding `window-right'.

The functions you are interested in are either

`window-next-sibling' and `window-prev-sibling' plus `window-combined-p'
   where the latter is needed to find out whether any such sibling is
   horizontally or vertically aligned - an information `window-right' and
   `window-left' won't give you anyway, or

`window-in-direction'.

If you tell me more precisely how you want to use them, I can provide
more information.

martin

Re: question about pop-to-buffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

>> Also, I have noticed that window-right/left can also handle vertical
>> splitting (I.e I was looking for something like window-above/bottom and
>> I discover that window-right/left do this).
>> Maybe that can be documented somewhere?
>
> No, and I probably should have called them window--right and
> window--left, but I faintly recall having called them from somewhere
> outside window.el.  These functions are only useful to avoid writing
>
>   (and window (window-parent window) (window-next-sibling window)))
>
> which is needed for technical reasons because usually the minibuffer
> window is the "sibling" of the frame's root window and the window tree
> functions should not work on the minibuffer window.  Anyone interested
> finds the rationale in the comment preceding `window-right'.
>
> The functions you are interested in are either
>
> `window-next-sibling' and `window-prev-sibling' plus `window-combined-p'
>   where the latter is needed to find out whether any such sibling is
>   horizontally or vertically aligned - an information `window-right' and
>   `window-left' won't give you anyway, or
>
> `window-in-direction'.
>
> If you tell me more precisely how you want to use them, I can provide
> more information.
I want a function that return the window at the left of the selected one
or nil if none.
Same for above, right, below.

If a window is returned I use it, otherwise (nil) I use the selected
one.

Actually I use window-left/right and it works fine, but IIUC, I don't
need the first checking:
(and window (window-parent window) (window-next-sibling window)))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I can use directly window-next/prev-sibling, right?

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Re: question about pop-to-buffer

[martin rudalics]

 > I want a function that return the window at the left of the selected one
 > or nil if none.
 > Same for above, right, below.

Then I suppose `window-in-direction' is the function you want.

 > If a window is returned I use it, otherwise (nil) I use the selected
 > one.
 >
 > Actually I use window-left/right and it works fine, but IIUC, I don't
 > need the first checking:
 > (and window (window-parent window) (window-next-sibling window)))
 > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 >
 > I can use directly window-next/prev-sibling, right?

Probably.  But note that in a one-window frame after C-x 3 evaluating
(window-next-sibling) gets you the window on the right.  If you now do
C-x 2 and then evaluate (window-next-sibling) you get the window below.

martin

Re: question about pop-to-buffer

[Thierry Volpiatto]

martin rudalics <rudalics@gmx.at> writes:

>> I want a function that return the window at the left of the selected one
>> or nil if none.
>> Same for above, right, below.
>
> Then I suppose `window-in-direction' is the function you want.
Yes I finally use this one, works very well, thanks.


-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997