Problem with change of toolbar's margin

Problem with change of toolbar's margin

[Sun Yijiang]

GNU Emacs CVS version under Linux.

The variable tool-bar-button-margin controls the toolbar's height. 
When I set this variable to a value other than it's default value, for
example, 2 or '(1 . 1), the toolbar's buttons "margin" changes, but
toolbar's "height" remains, which is still
icon_height+default_margin_value*2.  This makes a blank bar at the
bottom of the toolbar, looks ugly : (

Default value of tool-bar-button-margin is 4, defined in C Source,  so
I guess if there's some bug in toolbar display (I did not check the
source) that make toolbar's height a "constant", not a variable being
updated by value changing of tool-bar-button-margin.

Re: Problem with change of toolbar's margin

[Kim F. Storm]

Sun Yijiang <sunyijiang@gmail.com> writes:

> GNU Emacs CVS version under Linux.
>
> The variable tool-bar-button-margin controls the toolbar's height. 
> When I set this variable to a value other than it's default value, for
> example, 2 or '(1 . 1), the toolbar's buttons "margin" changes, but
> toolbar's "height" remains, which is still
> icon_height+default_margin_value*2.  This makes a blank bar at the
> bottom of the toolbar, looks ugly : (
>
> Default value of tool-bar-button-margin is 4, defined in C Source,  so
> I guess if there's some bug in toolbar display (I did not check the
> source) that make toolbar's height a "constant", not a variable being
> updated by value changing of tool-bar-button-margin.

With some toolkits, the height of the tool-bar must be a multiple
of the default frame line height.  It is on my to-do list to fix
this, but not before 21.4 is released.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Problem with change of toolbar's margin

[Sun Yijiang]

I see. But is there any toolkit support more flexible frame height
under GNU/Linux?


On Wed, 08 Dec 2004 12:03:17 +0100, Kim F. Storm <storm@cua.dk> wrote:
> Sun Yijiang <sunyijiang@gmail.com> writes:
> 
> 
> 
> > GNU Emacs CVS version under Linux.
> >
> > The variable tool-bar-button-margin controls the toolbar's height.
> > When I set this variable to a value other than it's default value, for
> > example, 2 or '(1 . 1), the toolbar's buttons "margin" changes, but
> > toolbar's "height" remains, which is still
> > icon_height+default_margin_value*2.  This makes a blank bar at the
> > bottom of the toolbar, looks ugly : (
> >
> > Default value of tool-bar-button-margin is 4, defined in C Source,  so
> > I guess if there's some bug in toolbar display (I did not check the
> > source) that make toolbar's height a "constant", not a variable being
> > updated by value changing of tool-bar-button-margin.
> 
> With some toolkits, the height of the tool-bar must be a multiple
> of the default frame line height.  It is on my to-do list to fix
> this, but not before 21.4 is released.
> 
> --
> Kim F. Storm <storm@cua.dk> http://www.cua.dk
> 
>

Re: Problem with change of toolbar's margin

[Miles Bader]

> I see. But is there any toolkit support more flexible frame height
> under GNU/Linux?

The GTK version (--with-x-toolkit=gtk) uses the GTK toolbar, which looks nice.

-Miles