From: "Jan Djärv" <jan.h.d@swipnet.se>
To: martin rudalics <rudalics@gmx.at>
Cc: esabof@gmail.com, 14233@debbugs.gnu.org
Subject: bug#14233: 24.3; Don't constrain frame size to character multiples
Date: Mon, 22 Apr 2013 15:11:26 +0200 [thread overview]
Message-ID: <5064BF03-8A61-4C0E-AA6C-5197A177B61A@swipnet.se> (raw)
In-Reply-To: <5175042E.5020508@gmx.at>
Hello.
22 apr 2013 kl. 11:34 skrev martin rudalics <rudalics@gmx.at>:
> > For NS a maximized and fullscreen requests comes in as separate
> > requests, for X they are normal resize request.
> [...]
> > The problem is that you think from the W32 point of view where (if I
> > interepret you correctly), Emacs applies size hints after the resize
> > request has been delivered.
>
> I think so.
>
> > This is not so for NS and X. Any size in a resize request is
> > accepted. If it follows WM size hints, great, if it don't, who
> > cares?. The frame size is set to the size in the request anyway.
>
> IIUC we do care because we want to fit the frame's windows according to
> the incoming request.
In the future, yes, but we can't resize windows pixelwise yet.
>
> > So for NS and X, fullscreen, maximized and such is no problem. A
> > minor glitch in NS is that we calculate the maximized sizes ourself,
> > and these are rounded to character sizes. If windows could handle
> > pixel sizes, we could easily fix this.
>
> In any case, the maximized size of the frame is not necessarily an
> integral multiple of character sizes so the frame gets or should get
> resized pixelwise.
We don't do that now because we can't resize windows pixelwise yet.
>
> > But there is no restriction on NS and X11 frames to resize by pixel
> > (i.e. not character multiples).
>
> So by default, on Windows I always accept a maximize request and resize
> windows accordingly. For any other size request I process a non-rounded
> size iff the variable `frame-resize-pixelwise' is non-nil.
>
> On all other platforms, `frame-resize-pixelwise' has no impact. If and
> whether size hints are turned on and have any impact depends on settings
> for the window manager used and is of no concern to me. Whatever size
> is requested by the WM is processed without any rounding.
>
> The interface to the window subsystem will be the function
>
> change_frame_size (struct frame *f, int new_width, int new_height,
> bool pretend, bool delay, bool safe, bool pixelwise)
>
> which processes new_width and new_height in terms of pixels if pixelwise
> is non-nil.
>
This is insane. it means changing lots and lots of calls, and makes merging between branches harder.
Make a new function (change_frame_size_pixelwise for example), with the arguments above, and let change_frame_size call it with the last argument false.
Jan D.
next prev parent reply other threads:[~2013-04-22 13:11 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 23:58 bug#14233: 24.3; Don't constrain frame size to character multiples E Sabof
2013-04-20 0:17 ` Glenn Morris
2013-04-20 6:45 ` Eli Zaretskii
2013-04-20 8:53 ` martin rudalics
2013-04-20 9:11 ` Jan Djärv
2013-04-20 11:00 ` martin rudalics
2013-04-20 12:56 ` Jan Djärv
2013-04-20 13:13 ` Eli Zaretskii
2013-04-20 19:26 ` Jan Djärv
2013-04-20 19:54 ` Eli Zaretskii
2013-04-20 22:02 ` Drew Adams
2013-04-21 3:40 ` Stefan Monnier
2013-04-21 7:04 ` Jan Djärv
2013-04-21 9:28 ` martin rudalics
2013-04-21 17:05 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 14:17 ` Stefan Monnier
2013-04-21 9:27 ` martin rudalics
2013-04-21 9:27 ` martin rudalics
2013-04-20 20:47 ` E Sabof
2013-04-21 9:26 ` martin rudalics
2013-04-21 17:21 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 13:11 ` Jan Djärv [this message]
2013-04-22 15:36 ` martin rudalics
2013-04-22 16:11 ` Jan Djärv
2013-04-22 16:38 ` martin rudalics
2013-04-22 18:21 ` Eli Zaretskii
2013-04-23 6:52 ` martin rudalics
2013-04-23 16:28 ` Eli Zaretskii
2013-04-24 6:39 ` martin rudalics
2013-04-24 17:13 ` Eli Zaretskii
2013-04-23 11:58 ` Jan Djärv
2013-04-23 12:33 ` martin rudalics
2013-04-23 16:48 ` Eli Zaretskii
2013-04-24 6:39 ` martin rudalics
2013-04-24 16:54 ` Jan Djärv
2013-04-25 7:29 ` martin rudalics
2013-04-25 9:55 ` Jan Djärv
2013-04-25 11:58 ` martin rudalics
2013-04-25 15:47 ` Richard Stallman
2013-04-24 17:15 ` Eli Zaretskii
2013-04-24 17:50 ` Jan Djärv
2013-04-25 7:29 ` martin rudalics
2013-04-20 13:38 ` martin rudalics
2013-04-20 19:33 ` Jan Djärv
2013-04-20 16:22 ` Drew Adams
2013-04-20 17:12 ` Eli Zaretskii
2013-04-20 21:50 ` Drew Adams
2013-04-21 9:27 ` martin rudalics
2013-04-21 16:17 ` Drew Adams
2013-04-20 9:25 ` Eli Zaretskii
2013-04-20 11:01 ` martin rudalics
2013-04-20 11:32 ` Eli Zaretskii
2013-04-20 13:38 ` martin rudalics
2013-04-20 16:25 ` Eli Zaretskii
2013-04-20 17:35 ` martin rudalics
2013-04-20 17:48 ` E Sabof
2013-04-20 18:26 ` Eli Zaretskii
2013-04-21 9:26 ` martin rudalics
2013-04-21 15:03 ` Eli Zaretskii
2013-04-22 9:34 ` martin rudalics
2013-04-21 17:30 ` Jan Djärv
2013-04-22 9:34 ` martin rudalics
2013-04-22 13:12 ` Jan Djärv
2013-04-22 15:36 ` martin rudalics
2013-04-22 18:36 ` Eli Zaretskii
2013-04-23 6:54 ` martin rudalics
2013-04-23 16:29 ` Eli Zaretskii
2013-04-23 6:50 ` martin rudalics
2013-04-23 16:23 ` Eli Zaretskii
2013-04-24 6:38 ` martin rudalics
2013-04-24 17:09 ` Eli Zaretskii
2013-04-24 18:50 ` Stefan Monnier
2013-04-24 20:09 ` Jan Djärv
2013-04-25 7:31 ` martin rudalics
2013-04-25 10:02 ` Jan Djärv
2013-04-25 11:58 ` martin rudalics
2013-04-25 14:11 ` Jan Djärv
2013-04-25 7:30 ` martin rudalics
2013-04-25 7:29 ` martin rudalics
2013-04-25 16:24 ` Eli Zaretskii
2013-04-26 7:42 ` martin rudalics
2013-04-26 13:21 ` Stefan Monnier
2013-04-26 14:39 ` Drew Adams
2013-04-27 6:59 ` martin rudalics
2013-04-27 13:53 ` Drew Adams
2013-04-28 12:17 ` martin rudalics
2013-04-28 15:33 ` Drew Adams
2013-04-28 16:29 ` Drew Adams
2013-04-29 7:33 ` martin rudalics
2013-04-29 14:10 ` Drew Adams
2013-04-29 16:48 ` martin rudalics
2013-04-29 20:41 ` Drew Adams
2013-04-30 7:34 ` martin rudalics
2013-04-30 15:47 ` Drew Adams
2013-04-30 17:08 ` martin rudalics
2013-04-30 19:45 ` Drew Adams
2013-05-01 9:15 ` martin rudalics
2013-05-01 13:47 ` Drew Adams
2013-05-02 9:22 ` martin rudalics
2013-05-02 13:28 ` Drew Adams
2014-12-25 19:30 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5064BF03-8A61-4C0E-AA6C-5197A177B61A@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=14233@debbugs.gnu.org \
--cc=esabof@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.