From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#12502: 24.2.50; Debugger messes up current-buffer Date: Mon, 24 Sep 2012 14:38:01 +0200 Message-ID: <50605429.10900@gmx.at> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060608030804070001040902" X-Trace: ger.gmane.org 1348490373 31631 80.91.229.3 (24 Sep 2012 12:39:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Sep 2012 12:39:33 +0000 (UTC) Cc: 12502@debbugs.gnu.org To: Helmut Eller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 24 14:39:32 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TG7we-0007ty-HV for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 14:39:28 +0200 Original-Received: from localhost ([::1]:37277 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG7wZ-0005Iy-KH for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Sep 2012 08:39:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG7wR-0005If-SL for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 08:39:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TG7wL-0007Z4-4t for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 08:39:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TG7wL-0007Yt-1H for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 08:39:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TG7yA-00076j-6w for bug-gnu-emacs@gnu.org; Mon, 24 Sep 2012 08:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Sep 2012 12:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12502-submit@debbugs.gnu.org id=B12502.134849041827271 (code B ref 12502); Mon, 24 Sep 2012 12:41:02 +0000 Original-Received: (at 12502) by debbugs.gnu.org; 24 Sep 2012 12:40:18 +0000 Original-Received: from localhost ([127.0.0.1]:52302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TG7xS-00075m-9q for submit@debbugs.gnu.org; Mon, 24 Sep 2012 08:40:18 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:49943) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1TG7xQ-00075f-Qw for 12502@debbugs.gnu.org; Mon, 24 Sep 2012 08:40:17 -0400 Original-Received: (qmail invoked by alias); 24 Sep 2012 12:38:21 -0000 Original-Received: from 62-47-40-30.adsl.highway.telekom.at (EHLO [62.47.40.30]) [62.47.40.30] by mail.gmx.net (mp039) with SMTP; 24 Sep 2012 14:38:21 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/FlsptAIPF2g5AMThLbpgjtpbpAcmyvKipYbiB3+ O10R6QdXIZSmkc In-Reply-To: X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64844 Archived-At: This is a multi-part message in MIME format. --------------060608030804070001040902 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit > The debugger now changes the current buffer in the following situation: [...] > This is a regression to older versions. Thanks for the report. Would the attached patch fix it? BTW, I notice that you quite often run functions with a current buffer different from that of the selected window. In all these cases `quit-window' might misbehave for you because it does not restore the buffer that was current at the time the window's buffer was displayed. So if you see any problems in this context, please tell me. We then could try to restore the current buffer (optionally at least) too. martin --------------060608030804070001040902 Content-Type: text/plain; name="debug-restore-current-buffer.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="debug-restore-current-buffer.diff" === modified file 'lisp/emacs-lisp/debug.el' --- lisp/emacs-lisp/debug.el 2012-09-20 13:35:13 +0000 +++ lisp/emacs-lisp/debug.el 2012-09-24 12:30:50 +0000 @@ -273,7 +273,8 @@ (setq debugger-previous-window-height (window-total-size debugger-window)) ;; Unshow debugger-buffer. - (quit-restore-window debugger-window debugger-bury-or-kill)) + (quit-restore-window debugger-window debugger-bury-or-kill) + (set-buffer debugger-old-buffer)) ;; Restore previous state of debugger-buffer in case we were ;; in a recursive invocation of the debugger, otherwise just ;; erase the buffer and put it into fundamental mode. --------------060608030804070001040902--