From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12471: Avoid some signal-handling races, and simplify. Date: Sat, 22 Sep 2012 03:55:13 -0700 Organization: UCLA Computer Science Department Message-ID: <505D9911.2020704@cs.ucla.edu> References: <50590626.2070407@cs.ucla.edu> <83lig6yoim.fsf@gnu.org> <505AB299.9090605@cs.ucla.edu> <837grozizw.fsf@gnu.org> <505C1A75.9030509@cs.ucla.edu> <83mx0jydya.fsf@gnu.org> <505CA363.1000603@cs.ucla.edu> <836277xolr.fsf@gnu.org> <505CAE5B.8060802@cs.ucla.edu> <83zk4jw7sf.fsf@gnu.org> <505CC70B.6050308@cs.ucla.edu> <83obkywkmt.fsf@gnu.org> <505D7B33.4000504@cs.ucla.edu> <83haqqwhhv.fsf@gnu.org> <505D8799.8030905@cs.ucla.edu> <83mx0il69z.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348311328 874 80.91.229.3 (22 Sep 2012 10:55:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2012 10:55:28 +0000 (UTC) Cc: 12471@debbugs.gnu.org, lekktu@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 22 12:55:32 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TFNMw-0007yk-4J for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Sep 2012 12:55:30 +0200 Original-Received: from localhost ([::1]:52019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNMr-0004px-Hw for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Sep 2012 06:55:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNMo-0004ps-8d for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 06:55:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFNMn-0004Lv-9N for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 06:55:22 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38558) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFNMn-0004LM-5m for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 06:55:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TFNOQ-00076S-LR for bug-gnu-emacs@gnu.org; Sat, 22 Sep 2012 06:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Sep 2012 10:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12471-submit@debbugs.gnu.org id=B12471.134831141927294 (code B ref 12471); Sat, 22 Sep 2012 10:57:02 +0000 Original-Received: (at 12471) by debbugs.gnu.org; 22 Sep 2012 10:56:59 +0000 Original-Received: from localhost ([127.0.0.1]:48104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFNOM-00076B-P2 for submit@debbugs.gnu.org; Sat, 22 Sep 2012 06:56:59 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:47331) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TFNOH-000761-Jv for 12471@debbugs.gnu.org; Sat, 22 Sep 2012 06:56:55 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 0F2B439E800D; Sat, 22 Sep 2012 03:55:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3PaH1qnvgCfy; Sat, 22 Sep 2012 03:55:10 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 99D5039E8007; Sat, 22 Sep 2012 03:55:10 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0 In-Reply-To: <83mx0il69z.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64728 Archived-At: On 09/22/2012 03:07 AM, Eli Zaretskii wrote: > 'sys_kill' does not do what's expected from 'raise', far from it. It may not do what's expected for 'raise' for arbitrary Windows applications, yes. But it doesn't need to do that. All that's needed is what Emacs expects for 'raise'. > for existing library functions, the only sane way to replace them > is to have the replacement support all the features supported by the > function being replaced. But the proposed patch does not replace the existing 'raise'. so it doesn't need to worry about supporting everything that Windows 'raise' does. All the patch does is to tell Emacs to call 'sys_raise' where emacs.c would normally call 'raise'. This doesn't affect other calls to 'raise'. The Windows 'raise' function still exists, and will still do what it normally does on Windows, when any non-Emacs module calls it. > even if we want to support "only" the features you had in mind, > 'sys_kill' will need to be extended to support all the fatal signals The current trunk is already invoking sys_kill with all those signals. If this behavior isn't correct for Windows, it needs to be fixed, regardless of whether the proposed patch is applied. The proposed patch doesn't make this problem any worse, or any better.