From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Truncated fatal error messages Date: Sat, 22 Sep 2012 01:24:19 -0700 Organization: UCLA Computer Science Department Message-ID: <505D75B3.6020406@cs.ucla.edu> References: <83mx0iwkcn.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348302270 2913 80.91.229.3 (22 Sep 2012 08:24:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Sep 2012 08:24:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 22 10:24:35 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TFL0r-0003x0-Nc for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 10:24:33 +0200 Original-Received: from localhost ([::1]:41523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFL0n-0005su-55 for ged-emacs-devel@m.gmane.org; Sat, 22 Sep 2012 04:24:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFL0l-0005rx-7C for emacs-devel@gnu.org; Sat, 22 Sep 2012 04:24:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFL0k-0001nS-E7 for emacs-devel@gnu.org; Sat, 22 Sep 2012 04:24:27 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:48669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFL0j-0001mQ-2Q; Sat, 22 Sep 2012 04:24:25 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1B24339E8015; Sat, 22 Sep 2012 01:24:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e4oVuHBax9f8; Sat, 22 Sep 2012 01:24:16 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 80FA639E800D; Sat, 22 Sep 2012 01:24:16 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0 In-Reply-To: <83mx0iwkcn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153455 Archived-At: On 09/22/2012 01:08 AM, Eli Zaretskii wrote: > Isn't it better to allocate the buffer (with alloca) If we're worried about arbitrarily long output of strsignal, alloca won't work, since alloca can't go over a few kilobytes. And we can't use malloc here, since signal handlers can't malloc. In practice I expect the old code was fine, since signal descriptions are never that long. But since the issue has been raised, I modified the code to avoid the need to allocate an arbitrarily long buffer.