all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: hanche@math.ntnu.no, 12447@debbugs.gnu.org
Subject: bug#12447: 24.1.50; Stuck in garbage collection on OS X
Date: Wed, 19 Sep 2012 20:21:32 +0400	[thread overview]
Message-ID: <5059F10C.6070806@yandex.ru> (raw)
In-Reply-To: <83obl2yr19.fsf@gnu.org>

On 19.09.2012 19:24, Eli Zaretskii wrote:
>> Date: Wed, 19 Sep 2012 13:54:39 +0400
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> CC: jan.h.d@swipnet.se, 12447@debbugs.gnu.org, hanche@math.ntnu.no
>>
>> On 19.09.2012 6:54, Eli Zaretskii wrote:
>>>> I'll keep the workaround, though, as it reportedly also fixes the
>>>> long-standing OS X freeze bug.
>>>
>>> What workaround is that?
>>
>> The one I posted in #12326: calling timer-activate-when-idle with nil
>> DONT-WAIT argument.
>
> I don't think that's a workaround.  I think that's what js2 should do,
> if (AFAIU) it wants the timer handler be invoked once, after Emacs has
> been idle for more than 1 sec.

Maybe, but run-with-idle-timer calls it with DONT-WAIT t, and 
js2-mode-reset-timer is only supposed to be called in response to some 
user action.
So with your patch, it works effectively the same either way.

By the way, here's what run-with-idle-timer docstring says:
"Perform an action the next time Emacs is idle for SECS seconds."

Shouldn't this mean that it should also pass DONT-WAIT nil?

Below that, the docstring mentions what will happen if Emacs has been 
idle for N seconds (N < SECS), but doesn't clarify that if N => SECS, it 
will fire immediately.

>> https://github.com/mooz/js2-mode/commit/b02f4a0d72d0e2087038fe891e2580c4505415ef
>
> Btw, in this line:
>
>    (timer-activate-when-idle timer nil)))
>
> I think you can lose the last argument, since it is optional anyway.

Sure, I wrote it that way just to be explicit.





  reply	other threads:[~2012-09-19 16:21 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 21:08 bug#12447: 24.1.50; Stuck in garbage collection on OS X Harald Hanche-Olsen
2012-09-15  9:55 ` Jan Djärv
2012-09-15 11:07   ` Harald Hanche-Olsen
2012-09-15 12:31     ` Eli Zaretskii
2012-09-15 13:19       ` Harald Hanche-Olsen
2012-09-15 13:56         ` Eli Zaretskii
2012-09-15 14:23           ` Harald Hanche-Olsen
2012-09-15 14:37             ` Eli Zaretskii
2012-09-15 18:59     ` Jan Djärv
2012-09-16  9:15 ` Dmitry Gutov
2012-09-16 10:31   ` Eli Zaretskii
2012-09-16 10:44     ` Dmitry Gutov
2012-09-16 11:53       ` Eli Zaretskii
2012-09-16 12:07         ` Dmitry Gutov
2012-09-16 12:39           ` Eli Zaretskii
2012-09-16 13:25             ` Dmitry Gutov
2012-09-16 13:47               ` Eli Zaretskii
2012-09-16 14:25                 ` Dmitry Gutov
2012-09-16 14:54                   ` Eli Zaretskii
2012-09-16 15:56                     ` Dmitry Gutov
2012-09-18 15:05                       ` Eli Zaretskii
2012-09-18 17:29                         ` Jan Djärv
2012-09-18 20:08                           ` Eli Zaretskii
2012-09-19  0:27                         ` Dmitry Gutov
2012-09-19  2:54                           ` Eli Zaretskii
2012-09-19  7:41                             ` Harald Hanche-Olsen
2012-09-19 15:21                               ` Eli Zaretskii
2012-09-19  9:54                             ` Dmitry Gutov
2012-09-19 15:24                               ` Eli Zaretskii
2012-09-19 16:21                                 ` Dmitry Gutov [this message]
2012-09-19 16:38                                   ` Eli Zaretskii
2012-09-19 18:29                                     ` Dmitry Gutov
2012-09-20  4:04                                     ` Chong Yidong
2012-09-20 16:01                                       ` Eli Zaretskii
2012-09-21  3:31                                         ` Chong Yidong
2012-09-21  7:14                                           ` Eli Zaretskii
2012-09-21  9:09                                             ` Chong Yidong
2012-09-21  9:54                                               ` Eli Zaretskii
2012-09-21 14:26                                                 ` Chong Yidong
2012-09-22 13:18                                                   ` Eli Zaretskii
2012-09-21 10:49                                               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5059F10C.6070806@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=12447@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=hanche@math.ntnu.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.