From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 12447@debbugs.gnu.org, hanche@math.ntnu.no
Subject: bug#12447: 24.1.50; Stuck in garbage collection on OS X
Date: Sun, 16 Sep 2012 18:25:50 +0400 [thread overview]
Message-ID: <5055E16E.1070604@yandex.ru> (raw)
In-Reply-To: <83txuyqdtv.fsf@gnu.org>
On 16.09.2012 17:47, Eli Zaretskii wrote:
>> Date: Sun, 16 Sep 2012 17:25:35 +0400
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> CC: hanche@math.ntnu.no, 12447@debbugs.gnu.org
>>
>>> idle_timers = Vtimer_idle_list;
>>
>> Done that, recompiled, no difference in the example a sent previously.
>> Exactly because, I think, of the control flow you describe below:
>>
>>>> But no, it probably won't: the "guilty" commit made timer_check_2
>>>> actually return 0 after a timer fires (keeping true to the comment above
>>>> it), so a local copy would serve no purpose.
>>>
>>> timer_check_2 indeed returns, but then timer_check will call it again,
>>> because it continues calling timer_check_2 in a loop, until there's no
>>> ripe timer.
>>
>> Each time timer_check_2 is called, a new copy would be made from the
>> idle timers list, so the newly created timer would be reached during the
>> same call to 'timer_check'.
>
> But the first time timer_check_2 encounters an un-ripe timer, or gets
> to the end of the list of timers, it returns a non-zero 'nexttime'
> value, which should break the loop in timer_check. Why isn't this
> happening?
Maybe because the new timer is at the top of the list, and it's
considered ripe?
> Perhaps the problem is that the value of 'difference' is not
> initialized:
>
> while (CONSP (timers) || CONSP (idle_timers))
> {
> Lisp_Object timer = Qnil, idle_timer = Qnil;
> EMACS_TIME timer_time, idle_timer_time;
> EMACS_TIME difference; <<<<<<<<<<<<<<<<<<<<<<<<<<<<
>
> and then never set to any specific value, until here:
>
> else
> /* When we encounter a timer that is still waiting,
> return the amount of time to wait before it is ripe. */
> {
> UNGCPRO;
> return difference;
> }
>
> which causes us return garbage, potentially zero, to timer_check.
It's assigned to, though. When we encounter a timer that's not yet ripe.
next prev parent reply other threads:[~2012-09-16 14:25 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 21:08 bug#12447: 24.1.50; Stuck in garbage collection on OS X Harald Hanche-Olsen
2012-09-15 9:55 ` Jan Djärv
2012-09-15 11:07 ` Harald Hanche-Olsen
2012-09-15 12:31 ` Eli Zaretskii
2012-09-15 13:19 ` Harald Hanche-Olsen
2012-09-15 13:56 ` Eli Zaretskii
2012-09-15 14:23 ` Harald Hanche-Olsen
2012-09-15 14:37 ` Eli Zaretskii
2012-09-15 18:59 ` Jan Djärv
2012-09-16 9:15 ` Dmitry Gutov
2012-09-16 10:31 ` Eli Zaretskii
2012-09-16 10:44 ` Dmitry Gutov
2012-09-16 11:53 ` Eli Zaretskii
2012-09-16 12:07 ` Dmitry Gutov
2012-09-16 12:39 ` Eli Zaretskii
2012-09-16 13:25 ` Dmitry Gutov
2012-09-16 13:47 ` Eli Zaretskii
2012-09-16 14:25 ` Dmitry Gutov [this message]
2012-09-16 14:54 ` Eli Zaretskii
2012-09-16 15:56 ` Dmitry Gutov
2012-09-18 15:05 ` Eli Zaretskii
2012-09-18 17:29 ` Jan Djärv
2012-09-18 20:08 ` Eli Zaretskii
2012-09-19 0:27 ` Dmitry Gutov
2012-09-19 2:54 ` Eli Zaretskii
2012-09-19 7:41 ` Harald Hanche-Olsen
2012-09-19 15:21 ` Eli Zaretskii
2012-09-19 9:54 ` Dmitry Gutov
2012-09-19 15:24 ` Eli Zaretskii
2012-09-19 16:21 ` Dmitry Gutov
2012-09-19 16:38 ` Eli Zaretskii
2012-09-19 18:29 ` Dmitry Gutov
2012-09-20 4:04 ` Chong Yidong
2012-09-20 16:01 ` Eli Zaretskii
2012-09-21 3:31 ` Chong Yidong
2012-09-21 7:14 ` Eli Zaretskii
2012-09-21 9:09 ` Chong Yidong
2012-09-21 9:54 ` Eli Zaretskii
2012-09-21 14:26 ` Chong Yidong
2012-09-22 13:18 ` Eli Zaretskii
2012-09-21 10:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5055E16E.1070604@yandex.ru \
--to=dgutov@yandex.ru \
--cc=12447@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=hanche@math.ntnu.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.