From: Daniel Colascione <dancol@dancol.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: lekktu@gmail.com, rms@gnu.org, 12450@debbugs.gnu.org
Subject: bug#12450: Remove configure's --without-sync-input option.
Date: Sun, 16 Sep 2012 02:52:35 -0700 [thread overview]
Message-ID: <5055A163.2070600@dancol.org> (raw)
In-Reply-To: <50558C80.4080408@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
On 9/16/12 1:23 AM, Paul Eggert wrote:
> On 09/15/2012 11:10 PM, Eli Zaretskii wrote:
>> I still would like to have BLOCK_INPUT in xmalloc and friends,
>> conditioned on some global variable being non-zero.
>
> There is no need for that, if we've checked our signal handlers to
> make sure that they invoke only async-signal-safe functions.
>
> Conversely, if we don't check our signal handlers, and we
> are worried that signal handlers might be buggy and might be
> invoking non-async-signal-safe functions, we should put
> debugging wrappers around not only malloc and friends: we
> should wrap every call to every non-async-signal-safe
> function. But there must be hundreds of such functions, and
> it's not practical to wrap them all. It's much more practical
> to keep signal handlers small and simple, which is what we've
> already done.
>
> Leaving BLOCK_INPUT in xmalloc and friends would be a
> revenant of the bad old days when our signal handlers
> invoked the Lisp interpreter and ran random code. We're
> better off with the standard practice on GNU and POSIXish
> systems for the past four years, which is to not do that.
> That is why removing those BLOCK_INPUTs has long been on our
> TODO list. What this patch is doing, is marking that job as
> done, because it effectively has been done for four years on
> GNU and POSIXish platforms, and we can do it for MS-Windows
> now.
>
>> That thread left the MS-Windows case indeterminate.
>
> OK, but at this point we don't know of any real problems
> that we'd have by assuming SYNC_INPUT on MS-Windows.
> SYNC_INPUT is a much simpler model than non-SYNC_INPUT,
> so this is not surprising.
The cygw32 port uses SYNC_INPUT on Windows. I've been using it for
almost a year in one form or another, and I haven't noticed any
problems. There might be a few lurking bugs, however: one thing that
stands out is that w32term.c, unlike xterm.c, sets
interrupt_input_pending, but doesn't set pending_signals.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 235 bytes --]
next prev parent reply other threads:[~2012-09-16 9:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 7:54 bug#12450: Remove configure's --without-sync-input option Paul Eggert
2012-09-15 9:32 ` Eli Zaretskii
2012-09-15 10:14 ` Paul Eggert
2012-09-15 11:03 ` Eli Zaretskii
2012-09-15 19:59 ` Paul Eggert
2012-09-15 20:15 ` Eli Zaretskii
2012-09-15 20:31 ` Paul Eggert
2012-09-16 6:33 ` Eli Zaretskii
2012-09-16 7:47 ` Paul Eggert
2012-09-16 8:05 ` Eli Zaretskii
2012-09-16 8:17 ` Paul Eggert
2012-09-16 8:21 ` Eli Zaretskii
2012-09-16 8:24 ` Eli Zaretskii
2012-09-16 8:34 ` Paul Eggert
2012-09-16 8:53 ` Eli Zaretskii
2012-09-15 21:12 ` Stefan Monnier
2012-09-16 5:55 ` Eli Zaretskii
2012-09-16 14:58 ` Stefan Monnier
2012-09-16 15:45 ` Eli Zaretskii
2012-09-16 16:30 ` Paul Eggert
2012-09-16 18:40 ` Eli Zaretskii
2012-09-16 19:55 ` Jan Djärv
2012-09-16 18:37 ` Stefan Monnier
2012-09-16 9:33 ` Daniel Colascione
2012-09-16 10:43 ` Eli Zaretskii
2012-09-16 15:10 ` Stefan Monnier
2012-09-16 15:40 ` Eli Zaretskii
2012-09-15 22:18 ` Richard Stallman
2012-09-16 3:15 ` Paul Eggert
2012-09-16 6:10 ` Eli Zaretskii
2012-09-16 8:23 ` Paul Eggert
2012-09-16 8:32 ` Eli Zaretskii
2012-09-16 21:48 ` Paul Eggert
2012-09-17 7:42 ` Eli Zaretskii
2012-09-21 20:50 ` Paul Eggert
2012-09-22 9:03 ` Eli Zaretskii
2012-09-22 9:34 ` Paul Eggert
2012-09-22 9:50 ` Eli Zaretskii
2012-09-22 10:01 ` Paul Eggert
2012-09-16 9:52 ` Daniel Colascione [this message]
2012-09-16 10:44 ` Eli Zaretskii
2012-09-16 10:56 ` Daniel Colascione
2012-09-17 7:41 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5055A163.2070600@dancol.org \
--to=dancol@dancol.org \
--cc=12450@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=lekktu@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.