Change default toolkit to Gtk3?

Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

I'd like to suggest that we change the default toolkit to Gtk3, like so:

configure    (Gtk3 is tried, then Gtk2)
configure --with-x-toolkit=gtk  (as above)
configure --with-x-toolkit=gtk3 (try Gtk3 only).

Is that OK?

	Jan D.

Re: Change default toolkit to Gtk3?

[Paul Eggert]

On 09/08/2012 09:10 AM, Jan Djärv wrote:
> Hello.
> 
> I'd like to suggest that we change the default toolkit to Gtk3, like so:

That sounds good to me.

Would it also make sense to add new option
configure --with-x-toolkit=gtk2 ?
Or do you think that nobody will want Gtk2
anymore, so why bother?

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

8 sep 2012 kl. 22:09 skrev Paul Eggert <eggert@cs.ucla.edu>:

> On 09/08/2012 09:10 AM, Jan Djärv wrote:
>> Hello.
>> 
>> I'd like to suggest that we change the default toolkit to Gtk3, like so:
> 
> That sounds good to me.
> 
> Would it also make sense to add new option
> configure --with-x-toolkit=gtk2 ?
> Or do you think that nobody will want Gtk2
> anymore, so why bother?

The latter.

	Jan D.

Re: Change default toolkit to Gtk3?

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

> I'd like to suggest that we change the default toolkit to Gtk3, like so:
>
> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk3 (try Gtk3 only).

Fine by me.

Re: Change default toolkit to Gtk3?

[Ulrich Mueller]

>>>>> On Sat, 8 Sep 2012, Jan Djärv wrote:

> I'd like to suggest that we change the default toolkit to Gtk3, like so:

> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk3 (try Gtk3 only).

> Is that OK?

In Gentoo we needs a way for our ebuild to explicitly select Gtk2.
AFAICS, that wouldn't be possible any more?

How about this:

configure    (Gtk3 is tried, then Gtk2)
configure --with-x-toolkit=gtk  (as above)
configure --with-x-toolkit=gtk2 (try Gtk2 only).

Ulrich

Re: Change default toolkit to Gtk3?

[Chong Yidong]

Ulrich Mueller <ulm@gentoo.org> writes:

> How about this:
>
> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk2 (try Gtk2 only).

I don't think we should drop configure flags, so --with-x-toolkit=gtk3
needs to still be recognized.  So, it should be

configure    (Gtk3 is tried, then Gtk2)
configure --with-x-toolkit=gtk  (as above)
configure --with-x-toolkit=gtk3 (as above)
configure --with-x-toolkit=gtk2 (try Gtk2 only).

Re: Change default toolkit to Gtk3?

[Andreas Schwab]

Chong Yidong <cyd@gnu.org> writes:

> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk3 (as above)

I don't think it makes sense to try gtk2 when gtk3 is requested.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

9 sep 2012 kl. 08:25 skrev Ulrich Mueller <ulm@gentoo.org>:

>>>>>> On Sat, 8 Sep 2012, Jan Djärv wrote:
> 
>> I'd like to suggest that we change the default toolkit to Gtk3, like so:
> 
>> configure    (Gtk3 is tried, then Gtk2)
>> configure --with-x-toolkit=gtk  (as above)
>> configure --with-x-toolkit=gtk3 (try Gtk3 only).
> 
>> Is that OK?
> 
> In Gentoo we needs a way for our ebuild to explicitly select Gtk2.
> AFAICS, that wouldn't be possible any more?
> 
> How about this:
> 
> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk2 (try Gtk2 only).

I did not consider atomated builders/testers.  So I agree, an explicit gtk2 is needed.

9 sep 2012 kl. 08:49 skrev Chong Yidong <cyd@gnu.org>:

> 
> I don't think we should drop configure flags, so --with-x-toolkit=gtk3
> needs to still be recognized.  So, it should be
> 
> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk3 (as above)
> configure --with-x-toolkit=gtk2 (try Gtk2 only).

I agree.

9 sep 2012 kl. 09:13 skrev Andreas Schwab <schwab@linux-m68k.org>:

> I don't think it makes sense to try gtk2 when gtk3 is requested.
> 

I agree, it would also change its current meaning.

So this is what I will do if nobody objects:

configure    (Gtk3 is tried, then Gtk2)
configure --with-x-toolkit=gtk  (as above)
configure --with-x-toolkit=gtk3 (try Gtk3 only)
configure --with-x-toolkit=gtk2 (try Gtk2 only)

	Jan D.

Re: Change default toolkit to Gtk3?

[Ulrich Mueller]

>>>>> On Sun, 9 Sep 2012, Jan Djärv wrote:

>> In Gentoo we need a way for our ebuild to explicitly select Gtk2.

> I did not consider atomated builders/testers.

Not necessarily automated, but the problem arises e.g. if the build
host has both Gtk2 and Gtk3 but the target host has only Gtk2.

> So I agree, an explicit gtk2 is needed.

> [...]

> So this is what I will do if nobody objects:

> configure    (Gtk3 is tried, then Gtk2)
> configure --with-x-toolkit=gtk  (as above)
> configure --with-x-toolkit=gtk3 (try Gtk3 only)
> configure --with-x-toolkit=gtk2 (try Gtk2 only)

Looks good to me.

Ulrich

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

This has been checked in.  Do we want a NEWS-entry for this?

	Jan D.

9 sep 2012 kl. 12:25 skrev Ulrich Mueller <ulm@gentoo.org>:

>>>>>> On Sun, 9 Sep 2012, Jan Djärv wrote:
> 
>>> In Gentoo we need a way for our ebuild to explicitly select Gtk2.
> 
>> I did not consider atomated builders/testers.
> 
> Not necessarily automated, but the problem arises e.g. if the build
> host has both Gtk2 and Gtk3 but the target host has only Gtk2.
> 
>> So I agree, an explicit gtk2 is needed.
> 
>> [...]
> 
>> So this is what I will do if nobody objects:
> 
>> configure    (Gtk3 is tried, then Gtk2)
>> configure --with-x-toolkit=gtk  (as above)
>> configure --with-x-toolkit=gtk3 (try Gtk3 only)
>> configure --with-x-toolkit=gtk2 (try Gtk2 only)
> 
> Looks good to me.
> 
> Ulrich

Re: Change default toolkit to Gtk3?

[Chong Yidong]

Jan Djärv <jan.h.d@swipnet.se> writes:

> This has been checked in.  Do we want a NEWS-entry for this?

Yes, under "Installation Changes".  Thanks.

Re: Change default toolkit to Gtk3?

[Dmitry Antipov]

On 09/13/2012 12:23 AM, Jan Djärv wrote:

> This has been checked in.  Do we want a NEWS-entry for this?

Can you also adjust configure.ac so that an answer to "What toolkit
should Emacs use" question was one of GTK, GTK2 or GTK3 (if GTK
is used at all)?

Dmitry

Re: Change default toolkit to Gtk3?

[Ulrich Mueller]

>>>>> On Wed, 12 Sep 2012, Jan Djärv wrote:

> This has been checked in.

I don't know if it's related to this, but I see a minor problem in the
output of configure --with-x-toolkit=lucid:

   checking for xaw3d... checking for XawScrollbarSetThumb in -lXaw3d... yes
   yes; using Lucid toolkit

Ulrich

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

13 sep 2012 kl. 04:42 skrev Chong Yidong <cyd@gnu.org>:

> Jan Djärv <jan.h.d@swipnet.se> writes:
> 
>> This has been checked in.  Do we want a NEWS-entry for this?
> 
> Yes, under "Installation Changes".  Thanks.

Done.

	Jan D.

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

13 sep 2012 kl. 05:38 skrev Dmitry Antipov <dmantipov@yandex.ru>:

> On 09/13/2012 12:23 AM, Jan Djärv wrote:
> 
>> This has been checked in.  Do we want a NEWS-entry for this?
> 
> Can you also adjust configure.ac so that an answer to "What toolkit
> should Emacs use" question was one of GTK, GTK2 or GTK3 (if GTK
> is used at all)?

I'd rather not.  We don't distinguish between versions (Motif, X, NS) in other cases, so why here?

	Jan D.

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello.

13 sep 2012 kl. 07:21 skrev Ulrich Mueller <ulm@kph.uni-mainz.de>:

>>>>>> On Wed, 12 Sep 2012, Jan Djärv wrote:
> 
>> This has been checked in.
> 
> I don't know if it's related to this, but I see a minor problem in the
> output of configure --with-x-toolkit=lucid:
> 
>   checking for xaw3d... checking for XawScrollbarSetThumb in -lXaw3d... yes
>   yes; using Lucid toolkit
> 

It is not related, it probably has been that way for some time.  I'll see if I can restructure the messages.

	Jan D.

Re: Change default toolkit to Gtk3?

[Dmitry Antipov]

On 09/13/2012 10:15 AM, Jan Djärv wrote:

>> Can you also adjust configure.ac so that an answer to "What toolkit
>> should Emacs use" question was one of GTK, GTK2 or GTK3 (if GTK
>> is used at all)?
>
> I'd rather not.  We don't distinguish between versions (Motif, X, NS)
> in other cases, so why here?

OK, but this means that 109113 becomes useless.

Dmitry

Re: Change default toolkit to Gtk3?

[Jan Djärv]

Hello. 


13 sep 2012 kl. 09:04 skrev Dmitry Antipov <dmantipov@yandex.ru>:

> On 09/13/2012 10:15 AM, Jan Djärv wrote:
> 
>>> Can you also adjust configure.ac so that an answer to "What toolkit
>>> should Emacs use" question was one of GTK, GTK2 or GTK3 (if GTK
>>> is used at all)?
>> 
>> I'd rather not.  We don't distinguish between versions (Motif, X, NS)
>> in other cases, so why here?
> 
> OK, but this means that 109113 becomes useless.
> 

What is an "109113"?

      Jan D. 

Re: Change default toolkit to Gtk3?

[Dmitry Antipov]

On 09/13/2012 12:34 PM, Jan Djärv wrote:

>> OK, but this means that 109113 becomes useless.
>>
>
> What is an "109113"?
>
>        Jan D.
>

bzr log revno :-), or commit ID. Feel free to revert it
if you don't want to report GTK version from configure.

Dmitry

Re: Change default toolkit to Gtk3?

[Stefan Monnier]

> I'd rather not.  We don't distinguish between versions (Motif, X, NS)
> in other cases, so why here?

But we've never offered a way for the user to select which version of
motif/X/NS to use either.  So I think it would make sense to say "GTK2"
or "GTK3" depending on which one got chosen by `configure' in the end.
Not terribly important, but if it can be done cheaply, it's better to do it.


        Stefan

Re: Change default toolkit to Gtk3?

[Jan Djärv]

13 sep 2012 kl. 14:42 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

>> I'd rather not.  We don't distinguish between versions (Motif, X, NS)
>> in other cases, so why here?
> 
> But we've never offered a way for the user to select which version of
> motif/X/NS to use either.  So I think it would make sense to say "GTK2"
> or "GTK3" depending on which one got chosen by `configure' in the end.
> Not terribly important, but if it can be done cheaply, it's better to do it.
> 


Ok, done.

	Jan D.